Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed multiple arrow heads with DashedVMobject #4078

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

CobaltIII
Copy link

@CobaltIII CobaltIII commented Dec 29, 2024

Overview: What does this pull request change?

When a DashedVMobject is made, the arrow is duplicated and overlayed for every segment or 'dash'. This change makes it so that only one arrowhead is seen during it all. Fixes #3220 . Also makes the TipableVMobject.pop_tips() function more robust if we enter an object that does not have any tips on either side.

Motivation and Explanation: Why and how do your changes improve the library?

It fixes an issue I found on the issues tab. I think it makes the usage of dashed arrows and vectors easier and more aesthetically pleasing.

Links to added or changed documentation pages

Further Information and Comments

Fixes the issue given here #3220.

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

Copy link

@OliverStrait OliverStrait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for searching the cause of tip duplication.

  • Fixes the linked issue with this result

arrowTransp_ManimCE_v0 18 1

manim/mobject/geometry/arc.py Outdated Show resolved Hide resolved
@CobaltIII CobaltIII requested a review from OliverStrait January 2, 2025 11:59
@CobaltIII
Copy link
Author

CobaltIII commented Jan 8, 2025

@OliverStrait The tests were passing however in the last commit to the main branch, the readthedocs test wasn't conducted and it is creating an issue by making a string of color "#CCC>" which doesn't exist. The previous commits were fine and all were passing. I noticed this issue with a few other pull requests as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opacity of Vector() and DashedVMobject(Vector) (Manim 0.17.3)
2 participants