-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed multiple arrow heads with DashedVMobject
#4078
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OliverStrait The tests were passing however in the last commit to the main branch, the readthedocs test wasn't conducted and it is creating an issue by making a string of color "#CCC>" which doesn't exist. The previous commits were fine and all were passing. I noticed this issue with a few other pull requests as well. |
Overview: What does this pull request change?
When a DashedVMobject is made, the arrow is duplicated and overlayed for every segment or 'dash'. This change makes it so that only one arrowhead is seen during it all. Fixes #3220 . Also makes the
TipableVMobject.pop_tips()
function more robust if we enter an object that does not have any tips on either side.Motivation and Explanation: Why and how do your changes improve the library?
It fixes an issue I found on the issues tab. I think it makes the usage of dashed arrows and vectors easier and more aesthetically pleasing.
Links to added or changed documentation pages
Further Information and Comments
Fixes the issue given here #3220.
Reviewer Checklist