docker library: review nit cleanups

scripts/docker-library-build.sh

@@ -85,7 +85,8 @@ sort -u "$reffile" -o "$reffile"
 entries=$(wc -l < "$reffile")
 if [ "$entries" -lt ${#arches[@]} ]; then
 	echo "Only $entries architectures so far"
-	exit
+	# so we're not going to do anything until we have a full list.
+	exit 0
 fi
 
 # Don't remove file here. Leave a manual retrigger of
@@ -107,13 +108,6 @@ declare -a annotations=(
   "--annotation" "org.opencontainers.image.version=$mariadb_version+$commit"
   "--annotation" "org.opencontainers.image.revision=$commit")
 
-annotate() {
-  for item in "${annotations[@]}"; do
-    echo " --annotation" \""$item"\"
-  done
-}
-
-
 #
 # BUILD Image
 #

scripts/docker-library-manifest.sh

@@ -38,7 +38,9 @@ image=mariadb-${tarbuildnum}${ubi}
 
 if ! buildah manifest exists "$image"; then
 	echo "No manifest we can't push"
-	exit
+	# Not fatal, but this means logic can stay
+	# here rather than in bb steps.
+	exit 0
 fi
 
 #

scripts/docker-library-test.sh

@@ -15,7 +15,7 @@ fi
 
 if ! buildah manifest exists "$image"; then
 	echo "No manifest we can't test"
-	exit
+	exit 0
 fi
 #
 # TEST Image
@@ -24,7 +24,7 @@ fi
 if [ "${builderarch}" != amd64 ]; then
   export DOCKER_LIBRARY_START_TIMEOUT=350
   echo "Temporarily disable non-amd64 testing"
-  exit
+  exit 0
 else
   export DOCKER_LIBRARY_START_TIMEOUT=150
 fi