Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reverting back bbw workers #509

Merged
merged 8 commits into from
Jul 29, 2024
Merged

reverting back bbw workers #509

merged 8 commits into from
Jul 29, 2024

Conversation

grooverdan
Copy link
Member

@fauust any preference on on how to use newer qemu-user-static on ubuntu:latest (22.04 in gh actions terms).

@grooverdan
bbw unmask
6d5b861
@grooverdan
remove old dockerfiles
af9636b
@grooverdan
bbw centos/deb/fedora/rhel - remove scons - not required
774bafa 
scons was a former build system for Galera that was replaced
with cmake.
@grooverdan
bbw centos-stream9 - add s390x
3900f5f 
Unsure if will add this as a CI item, but
no immediate need to restrict the build of it
as a worker now.
@grooverdan
bbw-build container not rhel - no timesync needed
8369923
@RazvanLiviuVarzaru
Copy link
Collaborator

RazvanLiviuVarzaru commented Jul 24, 2024 •
edited
Loading

@grooverdan @fauust another workaround (it's not ideal, but gives us some breathing time before moving to ubuntu 24.04 and solve all build errors) could be something like this:

  build:
    runs-on: ${{ matrix.runner || 'ubuntu-latest' }}
...
...
      matrix:
        include:
         - dockerfile: centos.Dockerfile
           image: almalinux:8
           platforms: linux/amd64, linux/arm64/v8

         - dockerfile: sles.Dockerfile pip.Dockerfile
           image: registry.suse.com/bci/bci-base:15.6
           tag: sles15
           platforms: linux/amd64, linux/s390x
           **runner: ubuntu-24.04**

Tested on my fork. where almalinux is running on current ubuntu-latest (we could enforce the version to 22.04) and sles is on 24.04

@grooverdan
bbw centos:stream9 - use latest ubuntu so qemu for ppc64le
617a6d8 
Allows the sufficient emulation to connect to the EPEL respository
and hence be able to build this image on ppc64le.
@grooverdan
Copy link
Member Author

@RazvanLiviuVarzaru nice - it was centos-stream9 with the problem but I applied the same concept.

@grooverdan
opensuse - libfmt needs devel package
0f384f6 
Note - sles doesn't have the same devel package.
@grooverdan
Revert "bbw centos-stream9 - add s390x"
771b970 
This reverts commit 3900f5f.

Chicken/egg problem - s390x container needed to build galera-4
which is needed to build container. Missing s390x isn't a big problem
- we really only build LTS platforms for s390x.
@RazvanLiviuVarzaru RazvanLiviuVarzaru self-requested a review July 25, 2024 06:54
fauust
fauust requested changes Jul 25, 2024
View reviewed changes
.github/workflows/bbw_build_container.yml
@@ -13,7 +13,7 @@ on:

jobs:
build:
runs-on: ubuntu-24.04
runs-on: ${{ matrix.runner || 'ubuntu-latest' }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use ubuntu-22.04 or ubuntu-24.04 (not latest).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ubuntu-latest is 22.04 currenty in github action terms: https://docs.github.com/en/actions/using-jobs/choosing-the-runner-for-a-job#choosing-github-hosted-runners

Copy link
Collaborator

@RazvanLiviuVarzaru RazvanLiviuVarzaru Jul 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grooverdan We can lock ubuntu-latest to ubuntu-22.04 to prevent any future GitHub updates for -latest runner.
Let's merge this please when possible, I need to come up with some additions to this yml file for fedora40-valgrind.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that was my point, pining version is more predictable.

@fauust
Copy link
Collaborator

fauust commented Jul 25, 2024 •
edited
Loading

I was going to try to install qemu-static from Debian sid but that's maybe not as clean... So ok with this solution (but please don't use latest).

@grooverdan grooverdan enabled auto-merge (rebase) July 29, 2024 01:57
fauust
fauust requested changes Jul 29, 2024
View reviewed changes
.github/workflows/bbw_build_container.yml
@@ -13,7 +13,7 @@ on:

jobs:
build:
runs-on: ubuntu-24.04
runs-on: ${{ matrix.runner || 'ubuntu-latest' }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that was my point, pining version is more predictable.

@grooverdan grooverdan merged commit 137b3bf into MariaDB:dev Jul 29, 2024
28 of 29 checks passed
@RazvanLiviuVarzaru RazvanLiviuVarzaru mentioned this pull request Jul 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RazvanLiviuVarzaru RazvanLiviuVarzaru RazvanLiviuVarzaru approved these changes

@fauust fauust fauust approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grooverdan @RazvanLiviuVarzaru @fauust