Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Change default connection to database to use host different than dock…
…er container - After setting up the virtual environment for the project (note missing instruction how to work locally with venv in `Readme.md`) and after running the `makemigrations --dry-run` or starting the webserver, application is trying to connect with hardcoded hostname `db` used from Dockerfile - This patch allows to add multiple hostname from environment variable `DJANGO_ALLOWED_HOSTS` separated by delimiter (I liked `,`) and since the create type in settings.py is `list` type it is free to use first value from a list if/when needed. - Add `get()` method for `os.environ` which is returning `None` instead of `KeyError` and validate parameters that we need. Using this approach only `$ export DJANGO_DB_HOST DJANGO_USER_NAME DJANGO_USER_NAME_PASSWOR` is needed. - Update `docker/.env` with new added environment variable `DJANGO_DB_HOST` - Proof * No patch ``` $ export DJANGO_ALLOWED_HOSTS=localhost,127.0.0.1 $ ./manage.py makemigrations --dry-run /home/anel/mariadb/feedback-plugin-backend/env/lib/python3.8/site-packages/django/core/management/commands/makemigrations.py:105: RuntimeWarning: Got an error checking a consistent migration history performed for database connection 'default': (2005, "Unknown MySQL server host 'db' (-3)") warnings.warn( Migrations for 'feedback_plugin': feedback_plugin/migrations/0002_alter_rawdata_upload_time.py - Alter field upload_time on rawdata ``` * With patch ``` $ ./manage.py makemigrations --dry-run Migrations for 'feedback_plugin': feedback_plugin/migrations/0002_alter_rawdata_upload_time.py - Alter field upload_time on rawdata ``` - Also server gets started correctly ``` $ ./manage.py runserver Performing system checks... System check identified no issues (0 silenced). You have 19 unapplied migration(s). Your project may not work properly until you apply the migrations for app(s): admin, auth, contenttypes, feedback_plugin, sessions. Run 'python manage.py migrate' to apply them. May 30, 2022 - 14:51:50 Django version 3.2.13, using settings 'feedback_plugin.settings' Starting development server at http://127.0.0.1:8000/ Quit the server with CONTROL-C. ```
- Loading branch information