Skip to content

Commit

Permalink
Reapply "Workaround issue #560 by removing character-set-collations"
Browse files Browse the repository at this point in the history
This reverts commit 1e14bca.
but only for 11.3/11.4 which haven't been updated.
  • Loading branch information
grooverdan committed May 23, 2024
1 parent 0ddfb4e commit e067772
Show file tree
Hide file tree
Showing 6 changed files with 34 additions and 16 deletions.
2 changes: 2 additions & 0 deletions 11.3/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,8 @@ RUN set -ex; \
| xargs -rt -0 sed -Ei 's/^(bind-address|log|user\s)/#&/'; \
# don't reverse lookup hostnames, they are usually another container
printf "[mariadb]\nhost-cache-size=0\nskip-name-resolve\n" > /etc/mysql/mariadb.conf.d/05-skipcache.cnf; \
# Issue #560
sed -i -e '/character-set-collations/d' /etc/mysql/mariadb.conf.d/50-server.cnf; \
# Issue #327 Correct order of reading directories /etc/mysql/mariadb.conf.d before /etc/mysql/conf.d (mount-point per documentation)
if [ -L /etc/mysql/my.cnf ]; then \
# 10.5+
Expand Down
2 changes: 2 additions & 0 deletions 11.4/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,8 @@ RUN set -ex; \
| xargs -rt -0 sed -Ei 's/^(bind-address|log|user\s)/#&/'; \
# don't reverse lookup hostnames, they are usually another container
printf "[mariadb]\nhost-cache-size=0\nskip-name-resolve\n" > /etc/mysql/mariadb.conf.d/05-skipcache.cnf; \
# Issue #560
sed -i -e '/character-set-collations/d' /etc/mysql/mariadb.conf.d/50-server.cnf; \
# Issue #327 Correct order of reading directories /etc/mysql/mariadb.conf.d before /etc/mysql/conf.d (mount-point per documentation)
if [ -L /etc/mysql/my.cnf ]; then \
# 10.5+
Expand Down
2 changes: 2 additions & 0 deletions 11.5/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,8 @@ RUN set -ex; \
| xargs -rt -0 sed -Ei 's/^(bind-address|log|user\s)/#&/'; \
# don't reverse lookup hostnames, they are usually another container
printf "[mariadb]\nhost-cache-size=0\nskip-name-resolve\n" > /etc/mysql/mariadb.conf.d/05-skipcache.cnf; \
# Issue #560
sed -i -e '/character-set-collations/d' /etc/mysql/mariadb.conf.d/50-server.cnf; \
# Issue #327 Correct order of reading directories /etc/mysql/mariadb.conf.d before /etc/mysql/conf.d (mount-point per documentation)
if [ -L /etc/mysql/my.cnf ]; then \
# 10.5+
Expand Down
2 changes: 2 additions & 0 deletions Dockerfile.template
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,8 @@ RUN set -ex; \
| xargs -rt -0 sed -Ei 's/^(bind-address|log|user\s)/#&/'; \
# don't reverse lookup hostnames, they are usually another container
printf "[mariadb]\nhost-cache-size=0\nskip-name-resolve\n" > /etc/mysql/mariadb.conf.d/05-skipcache.cnf; \
# Issue #560
sed -i -e '/character-set-collations/d' /etc/mysql/mariadb.conf.d/50-server.cnf; \
# Issue #327 Correct order of reading directories /etc/mysql/mariadb.conf.d before /etc/mysql/conf.d (mount-point per documentation)
if [ -L /etc/mysql/my.cnf ]; then \
# 10.5+
Expand Down
14 changes: 12 additions & 2 deletions update.sh
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,16 @@ update_version()
-e '/memory\.pressure/,+7d' \
"$version/docker-entrypoint.sh"
sed -i -e 's/ REPLICA\$/ SLAVE$/' "$version"/healthcheck.sh
sed -i -e 's/\/run/\/var\/run\//g' "$version/Dockerfile"
sed -i -e 's/\/run/\/var\/run\//g' \
-e '/^# Issue #560/,+1d' \
"$version/Dockerfile"
;; # almost nothing to see/do here
10.5)
sed -i -e '/--old-mode/d' \
-e '/memory\.pressure/,+7d' "$version/docker-entrypoint.sh"
sed -i '/backwards compat/d' "$version/Dockerfile"
sed -i -e '/backwards compat/d' \
-e '/^# Issue #560/,+1d' \
"$version/Dockerfile"
;;
*)
sed -i -e '/^CMD/s/mysqld/mariadbd/' \
Expand All @@ -97,6 +101,8 @@ update_version()
# my_print_defaults didn't recognise --mysqld until 10.11
sed -i -e '0,/#ENDOFSUBSTITUTIONS/s/\([^-]\)mysqld/\1mariadbd/g' \
"$version/docker-entrypoint.sh"
sed -i -e '/^# Issue #560/,+1d' \
"$version/Dockerfile"
else
sed -i -e '0,/#ENDOFSUBSTITUTIONS/s/\mysqld/mariadbd/g' \
"$version/docker-entrypoint.sh"
Expand All @@ -119,6 +125,10 @@ update_version()
if [[ $version =~ 11.[01] ]]; then
sed -i -e 's/50-mysqld_safe.cnf/50-mariadb_safe.cnf/' "$version/Dockerfile"
fi
if [[ $version =~ 11.[012] ]] || [ "$version" = 10.11 ]; then
sed -i -e '/^# Issue #560/,+1d' \
"$version/Dockerfile"
fi
;&
esac

Expand Down
28 changes: 14 additions & 14 deletions versions.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,20 @@
"s390x"
]
},
"11.3": {
"milestone": "11.3",
"version": "11.3.2",
"fullVersion": "1:11.3.2+maria~ubu2204",
"releaseStatus": "Stable",
"supportType": "Short Term Support",
"base": "ubuntu:jammy",
"arches": [
"amd64",
"arm64v8",
"ppc64le",
"s390x"
]
},
"11.2": {
"milestone": "11.2",
"version": "11.2.4",
Expand Down Expand Up @@ -123,19 +137,5 @@
"arm64v8",
"ppc64le"
]
},
"11.3": {
"milestone": "11.3",
"version": "11.3.2",
"fullVersion": "1:11.3.2+maria~ubu2204",
"releaseStatus": "Stable",
"supportType": "Short Term Support",
"base": "ubuntu:jammy",
"arches": [
"amd64",
"arm64v8",
"ppc64le",
"s390x"
]
}
}

0 comments on commit e067772

Please sign in to comment.