Skip to content

Commit

Permalink
MDEV-35693: Improve SHOW REPLICA STATUS column sizes
Browse files Browse the repository at this point in the history
Resize SHOW REPLICA STATUS’s (more precisely, the `INFORMATION_SCHEMA`
table `SLAVE_STATUS`’s) columns to better match their possible values

Text columns that list an uncapped number of elements have expanded to
accept as many bytes as we could support in case of intentionally but
absurdly long lists. Particularly, the OG `Replicate_` ones were
incorrectly typed as singlular `Name()`s during MDEV-33526.

In response to `‘MAX_SLAVE_ERRMSG’ was not declared in this scope` in
Embedded builds, a new `#ifdef HAVE_REPLICATION` guard wraps
`slave_status_info` to skip this unused data in Replication-less builds.

Reviewed-by: Brandon Nesterenko <brandon.nesterenko@mariadb.com>
  • Loading branch information
ParadoxV5 committed Jan 18, 2025
1 parent 8ef37ad commit 86e253b
Show file tree
Hide file tree
Showing 4 changed files with 88 additions and 87 deletions.
2 changes: 1 addition & 1 deletion mysql-test/main/information_schema.result
Original file line number Diff line number Diff line change
Expand Up @@ -1341,7 +1341,7 @@ table_schema='information_schema' and
group by column_type order by num;
column_type group_concat(table_schema, '.', table_name) num
varchar(7) information_schema.ROUTINES,information_schema.VIEWS,information_schema.SLAVE_STATUS 3
varchar(20) information_schema.ALL_PLUGINS,information_schema.ALL_PLUGINS,information_schema.ALL_PLUGINS,information_schema.FILES,information_schema.FILES,information_schema.PLUGINS,information_schema.PLUGINS,information_schema.PLUGINS,information_schema.PROFILING,information_schema.SLAVE_STATUS 10
varchar(20) information_schema.ALL_PLUGINS,information_schema.ALL_PLUGINS,information_schema.ALL_PLUGINS,information_schema.FILES,information_schema.FILES,information_schema.PLUGINS,information_schema.PLUGINS,information_schema.PLUGINS,information_schema.PROFILING 9
create table t1(f1 char(1) not null, f2 char(9) not null)
default character set utf8;
select CHARACTER_MAXIMUM_LENGTH, CHARACTER_OCTET_LENGTH from
Expand Down
Loading

0 comments on commit 86e253b

Please sign in to comment.