Skip to content

Commit

Permalink
MDEV-35693: Improve SSS column sizes
Browse files Browse the repository at this point in the history
Resize SHOW REPLICA STATUS’s (more precisely, the `INFORMATION_SCHEMA`
table `SLAVE_STATUS`’s) columns to better match their possible values.

In particular, many text columns – namely `Replicate_` ones – could
overflow (read: truncate) if the data is absurdly (but validly) long.
  • Loading branch information
ParadoxV5 committed Jan 17, 2025
1 parent e1abe7c commit 9737d59
Show file tree
Hide file tree
Showing 4 changed files with 101 additions and 88 deletions.
15 changes: 14 additions & 1 deletion mysql-test/main/information_schema.result
Original file line number Diff line number Diff line change
Expand Up @@ -903,6 +903,19 @@ information_schema PROCESSLIST INFO
information_schema ROUTINES DTD_IDENTIFIER
information_schema ROUTINES ROUTINE_DEFINITION
information_schema ROUTINES ROUTINE_COMMENT
information_schema SLAVE_STATUS Replicate_Do_DB
information_schema SLAVE_STATUS Replicate_Ignore_DB
information_schema SLAVE_STATUS Replicate_Do_Table
information_schema SLAVE_STATUS Replicate_Ignore_Table
information_schema SLAVE_STATUS Replicate_Wild_Do_Table
information_schema SLAVE_STATUS Replicate_Wild_Ignore_Table
information_schema SLAVE_STATUS Replicate_Ignore_Server_Ids
information_schema SLAVE_STATUS Gtid_IO_Pos
information_schema SLAVE_STATUS Replicate_Do_Domain_Ids
information_schema SLAVE_STATUS Replicate_Ignore_Domain_Ids
information_schema SLAVE_STATUS Slave_SQL_Running_State
information_schema SLAVE_STATUS Replicate_Rewrite_DB
information_schema SLAVE_STATUS Gtid_Slave_Pos
information_schema SYSTEM_VARIABLES ENUM_VALUE_LIST
information_schema TRIGGERS ACTION_CONDITION
information_schema TRIGGERS ACTION_STATEMENT
Expand Down Expand Up @@ -1341,7 +1354,7 @@ table_schema='information_schema' and
group by column_type order by num;
column_type group_concat(table_schema, '.', table_name) num
varchar(7) information_schema.ROUTINES,information_schema.VIEWS,information_schema.SLAVE_STATUS 3
varchar(20) information_schema.ALL_PLUGINS,information_schema.ALL_PLUGINS,information_schema.ALL_PLUGINS,information_schema.FILES,information_schema.FILES,information_schema.PLUGINS,information_schema.PLUGINS,information_schema.PLUGINS,information_schema.PROFILING,information_schema.SLAVE_STATUS 10
varchar(20) information_schema.ALL_PLUGINS,information_schema.ALL_PLUGINS,information_schema.ALL_PLUGINS,information_schema.FILES,information_schema.FILES,information_schema.PLUGINS,information_schema.PLUGINS,information_schema.PLUGINS,information_schema.PROFILING 9
create table t1(f1 char(1) not null, f2 char(9) not null)
default character set utf8;
select CHARACTER_MAXIMUM_LENGTH, CHARACTER_OCTET_LENGTH from
Expand Down
Loading

0 comments on commit 9737d59

Please sign in to comment.