-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MDEV-35304: Add Connects_Tried
and Primary_Retry_Count
to SSS
#3764
Draft
ParadoxV5
wants to merge
5
commits into
main
Choose a base branch
from
mdev-35304
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
50998cb
slave.cc `try_to_reconnect` remove `retry_counter`
ParadoxV5 a6e31e1
`slave.cc`: Refactor `reconnect_messages`
ParadoxV5 a62b686
MDEV-35304: Add `Connects_Tried` and `Primary_Retry_Count` to SSS
ParadoxV5 4c61ff4
misc. `sql/slave.cc` & co. refactor
ParadoxV5 7353053
update `.result`s of bad tests
ParadoxV5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The visibility on the
--master-retry-count
config together with the other new output was part of MDEV-35304 (and its customer)’s request.But I agree that the change from
master_retry_count
tomi->retry_count
belongs to MDEV-25674 better.I included that
::retry_count
because, like you said, SHOW REPLICA STATUS reportsMaster_info
entries, not global configs.I’ve requested assigning MDEV-25674 to myself and, especially re. your criticism, plan to include it in this PR too.
I’ll think about what’s the best sequence to reorganize the commit history to.
So MDEV-18777 is too soon for new columns by themselves? 👌
Much agreed – this name is so unfluent.
I was also thinking about deprecating
--master-retry-count
itself too in favor of MDEV-25674. This could be another argument.Switching to the ‘primary’ term as part of a “rename” is quite tempting though.
Or maybe throw out the ‘master’ part like
Connect_Tried
did (for disambiguation) –Max_Connect_Tries
? 🤔 clean