[WIP] Source versioning #693
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbyiliev
force-pushed
the
wip-source-versioning
branch
from
910e645 to
e4eb70d
Compare
Use source table instead of table from source MySQL source: separate for tables and all tables Loadgen source: add all tables bool attr Add tests Add more tests for mysql and loadgen Add ignore columns for MySQL Add source_id logic Add source table migration guide Ignore text columns for load gen source tables Refactor source table for individual sources Add datasource Format examples Add Kafka source table resource Review updates Update guide migration guide Update guide migration guide Add import examples for Kafka source tables Add upstream mysql and postgres table names PR change requests
bobbyiliev
force-pushed
the
wip-source-versioning
branch
from
e4eb70d to
eea81c6
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on-hold but this is the initial implementation for the source versioning refactor as per #646
The main changes to consider:
tableattribute as optional and deprecated for both the MySQL and Postgres sourcesall_tablesbool attribute for the MySQL and the Loadgen sources, as in the past this was defaulting always usingFOR ALL TABLESin the load gen sources (auction, marketing, tpch) and in the MySQL case whenever notableblocks were defined, we defaulted toFOR ALL TABLES. Thisall_tablesbool attribute allows us to create sources without any tables defined as per the source versioning workmaterialize_source_table_{mysql|postgres|load_generator}resource which allows us to doCREATE TABLE ... FROM SOURCE ...Things that are still pending: #646
Currently missing tests for the webhook source.
Fixes #686
Fixes #602
Covers most of the tasks under #646