Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage Environments - simplify Make #38

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

mo-marqh
Copy link
Member

@mo-marqh mo-marqh commented Dec 2, 2024

this PR updates the Environment management processes for the platforms using this code.

The responsibility for setting environment variables is fully put onto the environment setup, with no changes in any Makefile instances. This simplifies the Makefiles and puts all of the platform specific code in one place per platform.

The requirements are for
LD_LIBRARY_PATH, LDFLAGS, FCFLAGS & FC
to be provided to enable all builds on the platform

this change makes it slightly clearer to add a new platform, as evidenced by the azSpice addition

this change should also simplify addressing #34 & #37

it does not address #35, which is addressed within #36 (as yet unmerged)

Copy link
Collaborator

@harry-shepherd harry-shepherd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me, and I will approve these changes

@harry-shepherd harry-shepherd merged commit 897d50e into MetOffice:main Dec 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants