Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up "Win32 sample app" article #2614

Merged

Conversation

mikehoffms
Copy link
Collaborator

@mikehoffms mikehoffms commented May 30, 2023

Rendered article for review:
https://review.learn.microsoft.com/microsoft-edge/webview2/samples/webview2apissample?branch=pr-en-us-2614
Before:
https://learn.microsoft.com/en-us/microsoft-edge/webview2/samples/webview2apissample

The present PR improves the regular docs article about the main, Win32 WebView2 sample.

  • Reduces the number of year-specific mentions of Visual Studio versions.
  • Updates the screenshots of the app.
  • Structural edit to improve and clarify the final section of the article, which explains how the app works.
    • Clarifies subheadings.

Companion PR (merged) in WebView2Samples repo: MicrosoftEdge/WebView2Samples#194 (Streamline Win32 sample Readme, update screenshot).

AB#44840875

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@mikehoffms mikehoffms marked this pull request as ready for review June 1, 2023 23:53
@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@mikehoffms mikehoffms changed the title Win32 sample cleanup Clean up "Win32 sample app" article Jun 9, 2023
@learn-build-service-prod

This comment was marked as outdated.

@captainbrosset captainbrosset added the cat: webview2 WebView-related content. label Jun 21, 2023
@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod
Copy link

Learn Build status updates of commit 37bc76e:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/webview2/samples/webview2apissample.md ✅Succeeded View
microsoft-edge/webview2/samples/webview2apissample-images/sample-app-layout-diagram.png ✅Succeeded View
microsoft-edge/webview2/samples/webview2apissample-images/webview2apisample-app-window.png ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit fbc59bb:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/webview2/samples/webview2apissample.md ✅Succeeded View
microsoft-edge/webview2/samples/webview2apissample-images/sample-app-layout-diagram.png ✅Succeeded View
microsoft-edge/webview2/samples/webview2apissample-images/webview2apisample-app-window.png ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@Reezaali Reezaali merged commit ee444c2 into MicrosoftDocs:main Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: webview2 WebView-related content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants