Fixed NAK response

MillerTechnologyPeru · Apr 19, 2021 · c876f4d · c876f4d
1 parent 710d793
commit c876f4d
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/Sources/MPPSolar/MPPSolar.swift b/Sources/MPPSolar/MPPSolar.swift
@@ -36,12 +36,7 @@ public final class MPPSolar {
         let responseString = try send(command.rawValue)
         // parse response string
         guard let response = T.Response.init(rawValue: responseString) else {
-            if let acknowledgement = Acknowledgement(rawValue: responseString),
-                acknowledgement == .notAcknowledged {
-                throw MPPSolarError.notAcknowledged
-            } else {
-                throw MPPSolarError.invalidResponse(command.data)
-            }
+            throw MPPSolarError.invalidResponse(command.data)
         }
         return response
     }
@@ -61,6 +56,9 @@ public final class MPPSolar {
         // validate checksum
         guard responseChecksum == expectedChecksum
             else { throw MPPSolarError.invalidChecksum(responseChecksum, expected: expectedChecksum) }
+        guard responseString != Acknowledgement.notAcknowledged.rawValue else {
+            throw MPPSolarError.notAcknowledged
+        }
         return responseString
     }
 }