Skip to content

Commit

Permalink
Un-"fix" tests, fix code instead
Browse files Browse the repository at this point in the history
  • Loading branch information
@AntonOresten
AntonOresten committed Mar 17, 2024
1 parent b167702 commit 53e215a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/frames.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ Base.getindex(frames::Frames{T}, i::Integer) where T = Frame{T}(QuatRotation(fra

Base.:(==)(frames1::Frames, frames2::Frames) = all(f1 == f2 for (f1, f2) in zip(frames1, frames2))

function (frames::Frames{T})(coords::AbstractMatrix{T}) where T <: Real
function (frames::Frames{T})(coords::AbstractMatrix{<:Real}) where T <: Real
coords = T.(coords)
coords_centroid = centroid(coords)
return stack((f -> f(coords, coords_centroid)).(frames))
Expand Down
4 changes: 2 additions & 2 deletions test/frames.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import Rotations: QuatRotation, params
params(QuatRotation([0 0 1; 1 0 0; 0 1 0])^2);;
params(QuatRotation([0 0 1; 1 0 0; 0 1 0])^3);;
],
Float64[
[
0 10 100;
0 0 0;
0 0 0;
Expand All @@ -23,7 +23,7 @@ import Rotations: QuatRotation, params
@test size(frames) == (3,)
@test frames[1] == Frame{Float64}(QuatRotation([0 0 1; 1 0 0; 0 1 0]), [0.0, 0.0, 0.0])

standard_coords = Float64[3 1 -4; 1 -1 0; 0 0 0]
standard_coords = [3 1 -4; 1 -1 0; 0 0 0]
backbone = Backbone(frames, standard_coords)

@test backbone.coords == [
Expand Down

4 comments on commit 53e215a

@AntonOresten
Copy link
Member Author

@AntonOresten AntonOresten commented on 53e215a Mar 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

Release notes:

  • Add a manual precompilation step for common methods using PrecompilationTools.
  • Minor fixes

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/103027

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.9.2 -m "<description of version>" 53e215a9fcf24c51ad1b76a765aff90c8dd8d258
git push origin v0.9.2

@AntonOresten
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

Release notes:

  • Add a manual precompilation step for common methods using PrecompilationTools.
  • Minor fixes

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request updated: JuliaRegistries/General/103027

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.9.2 -m "<description of version>" 53e215a9fcf24c51ad1b76a765aff90c8dd8d258
git push origin v0.9.2

Please sign in to comment.