Skip to content

Commit

Permalink
Fix missing residue issue
Browse files Browse the repository at this point in the history
  • Loading branch information
AntonOresten committed May 17, 2024
1 parent 045ac34 commit 8e45203
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/ribbon/render.jl
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ function draw_lines_between_subchains!(
)
subchains = [chain[r] for r in subchain_ranges]
for (i, j) in zip(1:length(subchains)-1, 2:length(subchains))
startpoint, endpoint = subchains[i].backbone[end], subchains[j].backbone[begin]
startpoint, endpoint = subchains[i].backbone[end-1], subchains[j].backbone[begin+1]
n_segments = trunc(Int, norm(endpoint - startpoint) / 0.8)
xs, ys, zs = [LinRange(startpoint[i], endpoint[i], 2*n_segments) for i in 1:3]
linesegments!(ribbon, xs, ys, zs; linewidth=linewidth, color=color, transparency=true)
Expand Down

2 comments on commit 8e45203

@AntonOresten
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request updated: JuliaRegistries/General/107048

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.4.1 -m "<description of version>" 8e452033bc6b0ef68377dbc542553c5734b8318c
git push origin v0.4.1

Please sign in to comment.