Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

endian.h: fix so that this builds on NetBSD again. #233

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

he32
Copy link
Contributor

@he32 he32 commented Sep 21, 2024

A little ironic, since parts of this code is from NetBSD.

A little ironic, since parts of this code is *from* NetBSD.
@he32
Copy link
Contributor Author

he32 commented Sep 21, 2024

Previous build error was:

In file included from /usr/include/stdarg.h:37,
                 from ./include/zone.h:17,
                 from ./src/fallback/parser.c:9:
./src/generic/endian.h:125:31: error: expected declaration specifiers or '...' before '__builtin_constant_p'
  125 | static really_inline uint16_t bswap16(uint16_t x)
      |                               ^~~~~~~
./src/generic/endian.h:133:31: error: expected declaration specifiers or '...' before '__builtin_constant_p'
  133 | static really_inline uint32_t bswap32(uint32_t x)
      |                               ^~~~~~~
./src/generic/endian.h:144:31: error: expected declaration specifiers or '...' before '__builtin_constant_p'
  144 | static really_inline uint64_t bswap64(uint64_t x)
      |                               ^~~~~~~

Copy link
Contributor

@k0ekk0ek k0ekk0ek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @he32!

@k0ekk0ek k0ekk0ek merged commit 9a595d5 into NLnetLabs:main Sep 22, 2024
6 checks passed
@obache
Copy link

obache commented Sep 27, 2024

This issue should be already resolved with #231, so this change is not required.

@k0ekk0ek k0ekk0ek mentioned this pull request Sep 27, 2024
@k0ekk0ek
Copy link
Contributor

I'll have a look next week @obache (created #234). Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants