Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move async position into data dict for valid intermediate jsonl #333

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

titu1994
Copy link
Collaborator

Changelog

  • Moves the async position field into the data dictionary with a private key, so that the intermediate json is still valid

Signed-off-by: smajumdar <titu1994@gmail.com>
Signed-off-by: smajumdar <titu1994@gmail.com>
Signed-off-by: smajumdar <titu1994@gmail.com>
Copy link
Collaborator

@Kipok Kipok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Kipok Kipok merged commit ee863f3 into main Jan 28, 2025
4 checks passed
@titu1994 titu1994 deleted the update_async branch January 28, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants