Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Operators and Integration with cudensitymat #2407

Draft
wants to merge 86 commits into
base: main
Choose a base branch
from
Draft

[WIP] Operators and Integration with cudensitymat #2407

wants to merge 86 commits into from

Conversation

sacpis
Copy link
Collaborator

@sacpis sacpis commented Nov 25, 2024

Adding missing operations in operators

Co-authored with @anthony-santana.

@sacpis sacpis requested review from bettinaheim and 1tnguyen and removed request for bettinaheim and 1tnguyen November 25, 2024 04:48
amccaskey
amccaskey reviewed Nov 25, 2024
View reviewed changes
runtime/cudaq/dynamics/operators.h Outdated
@@ -0,0 +1,495 @@
/*******************************************************************************
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very excited for this feature. I appreciate all the work you two have done on this one. One thought here -

Operators are more broad that dynamics. Ideally this would be part of a cudaq/operators.h public header. Did we ever finish the language review for this feature? Would be good to get a meeting scheduled.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 3, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@sacpis sacpis force-pushed the dynamics_cpp_operators branch from 0f6496d to 791fb25 Compare December 19, 2024 19:50
@sacpis sacpis force-pushed the dynamics_cpp_operators branch from 2c1f0a2 to 92c922f Compare January 8, 2025 22:27
@sacpis sacpis closed this Jan 9, 2025
@sacpis sacpis force-pushed the dynamics_cpp_operators branch from 92c922f to da44eda Compare January 9, 2025 17:23
@sacpis sacpis temporarily deployed to ghcr-deployment January 9, 2025 17:24 — with GitHub Actions Inactive
github-actions bot pushed a commit that referenced this pull request Jan 9, 2025
@cuda-quantum-bot
Cleaning up docs preview for PR #2407.
84b9b79
@sacpis sacpis temporarily deployed to ghcr-deployment January 9, 2025 17:24 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jan 9, 2025
@cuda-quantum-bot
Docs preview for PR #2407.
1a2770b
@sacpis sacpis temporarily deployed to backend-validation January 10, 2025 03:08 — with GitHub Actions Inactive
@sacpis sacpis temporarily deployed to backend-validation January 10, 2025 03:09 — with GitHub Actions Inactive
@sacpis sacpis temporarily deployed to backend-validation January 10, 2025 03:09 — with GitHub Actions Inactive
bettinaheim and others added 28 commits February 3, 2025 20:07
@bettinaheim @sacpis
more memory experiments
08647e9 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
revised the data structures - all tests now pass again
1386d88 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
store one coefficient per product only
78d7cf6 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
getting rid of all elementary operator overloads
b17c9da 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
clean up for scalars
10af807 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
some clean up of op sum
0c4394f 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
some clean up for products
f853ce8 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
no type constraints for HandlerTy
e16f0c3 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
left hand arithmetics cleanup
e53348f 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
more clean up
6cceb21 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
more clean up
5598324 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
more clean up
4084b9d 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
finished cleanup of arithmetics
7942fff 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
picking up Anthony's changes
17b8aba 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
just a quick renaming
c9c1bc2 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
minor thing
067214c 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
minor thing
1781177 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
minor things
7e4f7e0 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
enabling a whole bunch of additional tests
4966002 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
some more product op fixes
5a31ba1 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
just some test fixes
7285a6f 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
fixing matrix reordering issues
0267cce 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
enabling the rest of the tests
37cca6d 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@sacpis
Adding template parameter HandlerTy for operator_sum and formatting
49d7823 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
Fixing Rydberg with template HandlerTy
a33df59 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
Fixing with template typename
b1ead80 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
Fixing HandlerTy tenplate by setting it to a value
d635ff8 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
Fixing unittests
8c91e88 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis sacpis force-pushed the dynamics_cpp_operators branch from 3e3909f to 8c91e88 Compare February 4, 2025 21:49
@sacpis
Adding missing functions in helpers and updating initialize_operator_…
c02ffdc 
…sum in test_cudm_helpers

Signed-off-by: Sachin Pisal <spisal@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1tnguyen 1tnguyen 1tnguyen left review comments

@amccaskey amccaskey amccaskey left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sacpis @amccaskey @1tnguyen @boschmitt @bettinaheim @anthony-santana @cuda-quantum-bot