Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First pass of support for C++ operators #2511

Open
wants to merge 111 commits into
base: experimental/operators
Choose a base branch
from
Open

First pass of support for C++ operators #2511

wants to merge 111 commits into from

Conversation

anthony-santana
Copy link
Collaborator

Description

This is an initial commit to the experimental branch containing a first pass of work towards operator support in C++

bmhowe23 and others added 5 commits January 13, 2025 08:05
@bmhowe23
Apply LLVM customizations for Python wheel build (NVIDIA#2504)
e246521 
This PR fixes an LLVM discrepancy in our Docker images vs our Python wheels. This should fix NVIDIA#1421 and NVIDIA#1799 for our Python wheels. (The Docker images were already correct.)
@bmhowe23
Make Python CUDA dependencies resolve for arm64, too (NVIDIA#2501)
b6655b6 
See also NVIDIA#1602
@bmhowe23
[ci] Update docker_images jobs to use more CPUs for build (NVIDIA#2505)
a9b50fc
@1tnguyen @schweitzpgi
Enable trajectory simulation for the nvidia target (NVIDIA#2466)
2c0fb3f 
* Docs for trajectory simulation

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

* Fix spelling and code format

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

* Update mgpu hash: include fixes for 2434

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

* Update docs/sphinx/snippets/cpp/using/backends/trajectory.cpp

Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
Signed-off-by: Thien Nguyen <58006629+1tnguyen@users.noreply.github.com>

* Update docs/sphinx/snippets/cpp/using/backends/trajectory.cpp

Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
Signed-off-by: Thien Nguyen <58006629+1tnguyen@users.noreply.github.com>

* Update docs/sphinx/snippets/cpp/using/backends/trajectory_observe.cpp

Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
Signed-off-by: Thien Nguyen <58006629+1tnguyen@users.noreply.github.com>

* Update docs/sphinx/snippets/cpp/using/backends/trajectory_observe.cpp

Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
Signed-off-by: Thien Nguyen <58006629+1tnguyen@users.noreply.github.com>

* Update python/cudaq/runtime/observe.py

Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
Signed-off-by: Thien Nguyen <58006629+1tnguyen@users.noreply.github.com>

---------

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>
Signed-off-by: Thien Nguyen <58006629+1tnguyen@users.noreply.github.com>
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
@1tnguyen
Make controlled rank a configurable setting (NVIDIA#2446)
742a31d 
For small controlled ops, i.e., singly controlled, expand the gate
matrix and use cutensornetStateApplyTensorOperator.

Add CUDAQ_TENSORNET_CONTROLLED_RANK threshold to determine when cutensornetStateApplyControlledTensorOperator is used.
For MPS, this is fixed at 1 as it cannot handle gate ops with more than
2 qubits.

Add doc for the setting and also remove some stale notes about random
seeds in the docs.

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 15, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

sacpis
sacpis approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@sacpis sacpis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if all tests are running successfully.

@sacpis sacpis force-pushed the dynamics_cpp_operators branch from 2b42628 to 8150d70 Compare January 16, 2025 22:10
1tnguyen and others added 3 commits January 18, 2025 07:14
@1tnguyen
Fix a bug in tensornet backend scratch pad allocation in multi-GPU mo…
9e0b590 
…de (NVIDIA#2516)

* Fix a bug in default init of scratchpad: it must allocate memory after we've set the device

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

* Add test

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

* Add a check to prevent multiple allocate calls

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

---------

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>
@khalatepradnya
[docs] Update the link to Python wheels (NVIDIA#2518)
a87e307 
Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
@bmhowe23
Follow-up to NVIDIA#2501 - Update Python install instructions (NVIDIA…
c96be85 
…#2519)

Signed-off-by: Ben Howe <bhowe@nvidia.com>
@sacpis sacpis force-pushed the dynamics_cpp_operators branch from 752fed1 to d55814d Compare January 21, 2025 17:11
khalatepradnya and others added 2 commits January 22, 2025 07:54
@khalatepradnya
[quera] Fix C++ frontend behavior (NVIDIA#2528)
7d70b43 
* Fix the behavior of `quera` backend with C++ frontend by showing appropriate error message.
  (Behavior prior to this change - default simulator was invoked)
* Tell nvq++ to generate glue for `quera`
* Simplify libraries - combine 'libcudaq-quera-qpu.so' and 'libcudaq-serverhelper-quera.so' into one.

Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
@1tnguyen
Update cuquantum-mgpu commit (NVIDIA#2530)
934b8c4 
Changes:

- cuda-quantum/cuquantum-mgpu!36: fix a bug in trajectory simulation

- cuda-quantum/cuquantum-mgpu!37: fix a bug in applyExpPauli: invalid
  value errors when the pauli word is acting on a subset of qubits.

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>
@sacpis sacpis force-pushed the dynamics_cpp_operators branch from 0ebeed5 to b592f8a Compare January 23, 2025 17:42
sacpis and others added 5 commits January 23, 2025 17:53
@sacpis
Upgrading notebook and jupyterlab version (NVIDIA#2524)
7da8635 
* Upgrading notebook version to 7.3.2 from 7.1.3

Signed-off-by: Sachin Pisal <spisal@nvidia.com>

* updating jupyterlab version to 4.3.4

Signed-off-by: Sachin Pisal <spisal@nvidia.com>

---------

Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@khalatepradnya
Follow-up to PR#2528: Make the newly added target test for quera ru…
88f4b75 
…n conditionally (NVIDIA#2532)

Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
@1tnguyen
Enable multi-GPU for dynamics target (NVIDIA#2509)
19c33af 
* [WIP] dynamics mgmn

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

* Fix a copy and paste error

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

* Handle initial state enum

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

* Update initial state enum example

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

* Add uniform state init

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

* Add uniform state init

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

* Update examples

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

* Code format

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

* Spelling

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

* Add more MPI API to CUDAQ comm plugin interface

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

* Refactor for dependency isolation

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

* Code format

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

* More isolation

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

* connect cuda-q mpi plugin to cudensitymat

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

* Fix for CI

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

* Code format: python

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

* Support initial state enum for non-dynamics case and add test

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

* Code tidy up and add docs

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

* Add MPI tests

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

* Add a link to the example directory

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

* Fix a typo

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

* Address CR: docs and comments edits; refactor to reduce code duplicate

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

---------

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>
@1tnguyen
[Tensornet] Update observe calculation (NVIDIA#2522)
db48d95 
* Add non path reuse option

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

* Add docs and test

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

* Code review: add a note about observe with tensornet and update code comments

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

---------

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>
@bmhowe23
[ci] Update runners to use -testing suffix for now (NVIDIA#2543)
5ee448d 
Signed-off-by: Ben Howe <bhowe@nvidia.com>
@sacpis sacpis force-pushed the dynamics_cpp_operators branch from 97bd0d6 to 3f00f9f Compare January 25, 2025 19:57
khalatepradnya and others added 3 commits January 27, 2025 17:26
@khalatepradnya
[braket] Add support for observe API (NVIDIA#2539)
1e9bf70 
Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
@bmhowe23
Revert "[ci] Update runners to use -testing suffix for now (NVIDIA#2543…
066746b 
…)" (NVIDIA#2548)

This reverts commit 5ee448d.

Since nv-gha-runners/vm-images#113 has been
merged, we can revert our temporary change.

Signed-off-by: Ben Howe <bhowe@nvidia.com>
@bmhowe23
Add support for -j option for build_cudaq.sh script (NVIDIA#2546)
bd49915 
Signed-off-by: Ben Howe <bhowe@nvidia.com>
@sacpis sacpis force-pushed the dynamics_cpp_operators branch from bbec3ed to 5b14fad Compare January 28, 2025 00:12
bettinaheim and others added 28 commits February 3, 2025 20:07
@bettinaheim @sacpis
more memory experiments
08647e9 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
revised the data structures - all tests now pass again
1386d88 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
store one coefficient per product only
78d7cf6 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
getting rid of all elementary operator overloads
b17c9da 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
clean up for scalars
10af807 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
some clean up of op sum
0c4394f 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
some clean up for products
f853ce8 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
no type constraints for HandlerTy
e16f0c3 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
left hand arithmetics cleanup
e53348f 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
more clean up
6cceb21 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
more clean up
5598324 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
more clean up
4084b9d 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
finished cleanup of arithmetics
7942fff 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
picking up Anthony's changes
17b8aba 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
just a quick renaming
c9c1bc2 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
minor thing
067214c 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
minor thing
1781177 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
minor things
7e4f7e0 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
enabling a whole bunch of additional tests
4966002 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
some more product op fixes
5a31ba1 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
just some test fixes
7285a6f 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
fixing matrix reordering issues
0267cce 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@bettinaheim @sacpis
enabling the rest of the tests
37cca6d 
Signed-off-by: Bettina Heim <heimb@outlook.com>
@sacpis
Adding template parameter HandlerTy for operator_sum and formatting
49d7823 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
Fixing Rydberg with template HandlerTy
a33df59 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
Fixing with template typename
b1ead80 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
Fixing HandlerTy tenplate by setting it to a value
d635ff8 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
Fixing unittests
8c91e88 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis sacpis force-pushed the dynamics_cpp_operators branch from 3e3909f to 8c91e88 Compare February 4, 2025 21:49
@sacpis
Adding missing functions in helpers and updating initialize_operator_…
c02ffdc 
…sum in test_cudm_helpers

Signed-off-by: Sachin Pisal <spisal@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sacpis sacpis sacpis approved these changes

@bettinaheim bettinaheim Awaiting requested review from bettinaheim bettinaheim is a code owner

@1tnguyen 1tnguyen Awaiting requested review from 1tnguyen 1tnguyen is a code owner

@bmhowe23 bmhowe23 Awaiting requested review from bmhowe23 bmhowe23 is a code owner

@schweitzpgi schweitzpgi Awaiting requested review from schweitzpgi schweitzpgi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@anthony-santana @sacpis @bmhowe23 @1tnguyen @khalatepradnya @Omar-ORCA @boschmitt @annagrin @cuda-quantum-bot @bettinaheim