Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[braket] Add the symbol-dce pass to the lowering pipeline #2583

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

khalatepradnya
Copy link
Collaborator

This also fixes the following (non-fatal) error seen during 'observe' error: 'func.func' op Invalid number of binary-symplectic elements provided. Must provide 2 * NQubits = 0
(Ref: #2539)

  • Manually ran the Braket test suite.
root@87c14fc11e0a:/workspaces/cuda-quantum/build# python3 -m pytest -rP ../python/tests/backends/test_braket.py
...                                                                                                                                   

../python/tests/backends/test_braket.py .......................                                                                                  [100%]

================================= PASSES =====================================
...
====================== 23 passed in 180.69s (0:03:00) ========================
{ 00:79 11:21 }
{ 00:25 01:19 10:26 11:30 }
{ 00:100 }
{ 0:53 1:47 }


root@87c14fc11e0a:/workspaces/cuda-quantum/build# bin/nvq++ --target braket ../docs/sphinx/targets/cpp/braket.cpp -o out.x && ./out.x
{ 00000:517 11111:483 }
{ 00000:494 11111:506 }

root@87c14fc11e0a:/workspaces/cuda-quantum/build# python3 ../docs/sphinx/targets/python/braket.py
{ 00:530 11:470 }

{ 00:507 11:493 }

  symbols are eliminated - resulting in simpler code.

* Also, fixes the following (non-fatal) error seen during 'observe'
`error: 'func.func' op Invalid number of binary-symplectic elements
provided. Must provide 2 * NQubits = 0`

* Manually ran the Braket test suite.

Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
@khalatepradnya khalatepradnya self-assigned this Feb 3, 2025
@khalatepradnya khalatepradnya enabled auto-merge (squash) February 3, 2025 23:10
Copy link
Collaborator

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pradnya!

Copy link

github-actions bot commented Feb 4, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 4, 2025
@khalatepradnya khalatepradnya merged commit 8af998e into NVIDIA:main Feb 4, 2025
213 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 4, 2025
@khalatepradnya khalatepradnya deleted the braket-fix branch February 4, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants