Add support for NeMo Customizer #305
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivamerla
requested review from
ArangoGutierrez,
slu2011 and
visheshtanksale
as code owners
shivamerla
force-pushed
the
add_nemo_customizer_support
branch
from
b3f6c00 to
ad941a9
Compare
shivamerla
requested review from
varunrsekar
and removed request for
ArangoGutierrez
varunrsekar
reviewed
Jan 31, 2025
Comment on lines
139
to
140
| // Enabled indicates whether Volcano scheduler is enabled | ||
| Enabled bool `json:"enabled,omitempty"` |
There was a problem hiding this comment.
i still want to keep this as for other microservices where this is optional, users can toggle the field dynamically without adding/removing entire spec.
shengnuo
reviewed
Jan 31, 2025
shengnuo
reviewed
Jan 31, 2025
Comment on lines
+37
to
+50
| // NemoCustomizerConditionReady indicates that the NEMO CustomizerService is ready. | ||
| NemoCustomizerConditionReady = "Ready" | ||
| // NemoCustomizerConditionFailed indicates that the NEMO CustomizerService has failed. | ||
| NemoCustomizerConditionFailed = "Failed" | ||
|
|
||
| // NemoCustomizerStatusPending indicates that NEMO CustomizerService is in pending state | ||
| NemoCustomizerStatusPending = "Pending" | ||
| // NemoCustomizerStatusNotReady indicates that NEMO CustomizerService is not ready | ||
| NemoCustomizerStatusNotReady = "NotReady" | ||
| // NemoCustomizerStatusReady indicates that NEMO CustomizerService is ready | ||
| NemoCustomizerStatusReady = "Ready" | ||
| // NemoCustomizerStatusFailed indicates that NEMO CustomizerService has failed | ||
| NemoCustomizerStatusFailed = "Failed" |
There was a problem hiding this comment.
I see all NeMo microservices use similar status type.
Maybe we should consider moving them under common_types.go
There was a problem hiding this comment.
yes, makes sense, can do that as a follow up.
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
shivamerla
force-pushed
the
add_nemo_customizer_support
branch
from
8af2740 to
977e421
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.