New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: settings restoring (Part 2) #780

Open

redrathnure wants to merge 1 commit into NanoVNA-Saver:main from redrathnure:fix/settings_2

+9 −10

Contributor

redrathnure commented Feb 1, 2025

Fix application settings restoring
It's a followup for #778, MyPy absence is bit frustrating

It fixes #777 and was mentioned in #768

Pull Request type

Please check the type of change your PR introduces:

Bugfix
[] Feature
[] Code style update (formatting, renaming)
[] Refactoring (no functional changes, no API changes)
[] Build-related changes
[] Documentation content changes
[] Other (please describe):

What is the current behavior?

some of settings (e.g. font size) are not restored between run sessions
sweep configuration is not saved between run sessions
app crashes right before exit

Issue Number: 777

What is the new behavior?

settings are saved on exit and restored on app start

Does this introduce a breaking change?

[] Yes
No

Other information


          fix: settings restoring

5fdb1d7

redrathnure requested a review from zarath as a code owner

February 1, 2025 21:23

redrathnure changed the title ~~fix: settings restoring~~ fix: settings restoring (Part 2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet