Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(charts/nd-common): Fix missing layout structure for sidecar resources layout #257

Merged
merged 5 commits into from
Jan 11, 2024

Conversation

scohen-nd
Copy link
Contributor

@scohen-nd scohen-nd commented Jan 11, 2024

  • Fix missing layout structure for sidecar resources layout.
  • Restructuring a cleaner template where the default values are in the values file instead of the code.
  • Update other charts to point to the updated nd-common.

@scohen-nd scohen-nd requested a review from a team as a code owner January 11, 2024 17:04
charts/nd-common/values.yaml Outdated Show resolved Hide resolved
charts/nd-common/templates/_istio.tpl Outdated Show resolved Hide resolved
@scohen-nd scohen-nd merged commit 316384f into main Jan 11, 2024
2 checks passed
@scohen-nd scohen-nd deleted the fix_sidecar_resources_annotations branch January 11, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants