chore(simple-app): remove uppercase transform of secret engine keys #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diranged
reviewed
Feb 17, 2024
schahal
changed the title
diranged
approved these changes
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some private feedback (and I tend to agree), we want to remove the
uppercasetransformation on secret property keys.As the rest of the engines (
plaintextandkms) are in abundant use, changing that would be BREAKING.I feel we can switch the
sealedengine template only, as adoption of that is nil (and IMO a breaking change later for the rest of the secret engines).I think the advantage of letting user explicitly set the key name (rather than doing a "behind-the-scenes" transformation) outweigh the cons (less friction finding/debugging secrets, some 3rd-party charts may require user to have a secret with a specifically styled key, etc)