feat(local-kafka): switch to kraft, start faster, allow annotations #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diranged
force-pushed
the
upgrade_kafka_faster
branch
from
ab6a0e9 to
f577e0e
Compare
diranged
force-pushed
the
upgrade_kafka_faster
branch
from
f577e0e to
75143f1
Compare
LaikaN57
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal for this PR is to improve the usability of the
local-kafkachart by reducing its startup time, introducing podAnnotations and removing old legacy settings:Change: Removed legacy startup/readiness probe delays
We no longer see the Strimzi Operator take minutes to start up on M1 laptops, so I am removing the arbitrary startup/readiness probe delays.
Change: Replace Zookeeper with KRaft
Strimzi is moving to removing Zookeeper entirely in the 0.46.0 release anyways ... this change gets our local testing setup that way ahead of the change. This also reduces the number of pods that have to run locally, reducing the total startup time of a full testing environment.
Change: Introduce
podAnnotationsandannotationssettingsIf you set
.Values.podAnnotations: { ... }now we will add these annotations to the Kafka and Entity Operator pods. This makes it easier to tell Helm to start these pods up before the rest of the tested resources get created.