Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux: enable FF support for hid-nvidia-shield #348329

Closed

Conversation

Binary-Eater
Copy link
Member

Enables FF support for 2017 NVIDIA SHIELD (Thunderstrike) controller.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Enables FF support for 2017 NVIDIA SHIELD (Thunderstrike) controller.

Signed-off-by: Rahul Rameshbabu <sergeantsagara@protonmail.com>
@github-actions github-actions bot added the 6.topic: kernel The Linux kernel label Oct 13, 2024
@Binary-Eater Binary-Eater requested a review from Ma27 October 14, 2024 03:46
@Ma27
Copy link
Member

Ma27 commented Oct 17, 2024

@Binary-Eater can you replace onto latest master, please? Seems like you're base branch is in a broken state, hence the red CI.

Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be OK with that, but would like to have a rebase to fix ofborg's evaluation before merging.

@Ma27 Ma27 requested review from K900 and alyssais October 17, 2024 15:49
@K900
Copy link
Contributor

K900 commented Oct 17, 2024

Doesn't need to go to staging anyway. I'll pull it into my kernel updates branch.

@K900
Copy link
Contributor

K900 commented Oct 17, 2024

Will include in #349289

@K900 K900 closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: kernel The Linux kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants