it-tools: init at 2024.10.22-7ca5933 #350285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
8.has: maintainer-list (update)
|
Hello, this is my first time contributing to nixpkgs, so please let me know if there is anything I've missed, thanks! |
NixOSInfra
added
the
12. first-time contribution
akotro
force-pushed
the
it-tools
branch
2 times, most recently
from
fc9ed4f to
80ab88f
Compare
ofborg
bot
added
8.has: package (new)
akotro
force-pushed
the
it-tools
branch
2 times, most recently
from
80ab88f to
b566f7c
Compare
akotro
changed the title
akotro
force-pushed
the
it-tools
branch
2 times, most recently
from
503c6a8 to
5a7d809
Compare
Atemu
approved these changes
Nov 6, 2024
Comment on lines
+29
to
+35
| buildPhase = '' | ||
| runHook preBuild | ||
|
|
||
| pnpm build | ||
|
|
||
| runHook postBuild | ||
| ''; |
There was a problem hiding this comment.
I'm not very familiar with pnpm but doesn't our hook run this by default, making this redundant?
cc @Scrumplex
There was a problem hiding this comment.
From my testing, this does not seem to be the case, but I can obviously be corrected by someone more knowledgeable.
Comment on lines
+37
to
+44
| installPhase = '' | ||
| runHook preInstall | ||
|
|
||
| mkdir -p $out/lib | ||
| cp -R ./dist/* $out/lib/ | ||
|
|
||
| runHook postInstall | ||
| ''; |
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
and removed
10.rebuild-darwin: 0
|
Hi @Atemu |
|
That's exactly what I wanted to know, thanks :) |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add it-tools, a website with useful tools for developers and people working in IT.
Fixes #348389 .
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.