epsonscan2: 6.7.70.0 -> 6.7.70.0-01-2025, pin boost, minor refactor #375409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Looks good to me.
|
james-atkins
approved these changes
Jan 21, 2025
Shawn8901
reviewed
Jan 21, 2025
wegank
added
the
12.approvals: 1
SigmaSquadron
force-pushed
the
push-vqmkootwuztr
branch
3 times, most recently
from
6057513 to
a3b7044
Compare
wegank
removed
the
12.approvals: 1
Shawn8901
approved these changes
Jan 23, 2025
Shawn8901
added
the
12.approvals: 1
3 tasks
Epson changes their projects without changing their versions because ¯\_(ツ)_/¯. They also provide no changelogs, because why would they? This seems to at least remove the CMakeCache.txt that was left in the source code distribution. Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
This software does not use C++11. Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
wegank
added
12.approvals: 2
SigmaSquadron
force-pushed
the
push-vqmkootwuztr
branch
from
a3b7044 to
5ad4b0d
Compare
- Removes a `pname` interpolation. - Updates the `longDescription` so it uses syntax-highlighting code blocks instead of <literal>. - Uses `lib.getExe` instead of hardcoding a `/bin/` path. - Uses the new `lib.systems` standard for declaring platforms. Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
SigmaSquadron
force-pushed
the
push-vqmkootwuztr
branch
from
5ad4b0d to
432c7e1
Compare
github-actions
bot
added
10.rebuild-darwin: 0
FliegendeWurst
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #376449
Updates the package to the latest release from Epson. Please see the comment in the file for an explanation as to why the version is the way it is.
Pins Boost 1.86 because Epson is too good for C++11.
Fixes up some minor things in the package.
I should also note that this package is currently failing on
master.Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.