Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.wsmatrix: new package #67876

Closed
wants to merge 1 commit into from
Closed

gnomeExtensions.wsmatrix: new package #67876

wants to merge 1 commit into from

Conversation

deepfire
Copy link
Contributor

@deepfire deepfire commented Sep 1, 2019

Add the wsmatrix extension to Ghome Shell (compatible with v3.32):

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 1, 2019
@deepfire
Copy link
Contributor Author

deepfire commented Sep 4, 2019

cc-ing some gnome shell extension maintainers: @aneeshusa @jonafato @svsdep @tiramiseb @timbertson

@deepfire
Copy link
Contributor Author

deepfire commented Sep 4, 2019

I think we might also deprecate workspace-grid, since it's:

  1. not even available (its nix definition isn't imported)
  2. unmaintained, with wsmatrix taking it over.

jonafato
jonafato suggested changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@jonafato jonafato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extension seems to work well, just a few requests to match naming and version conventions.

pkgs/desktops/gnome-3/extensions/wsmatrix.nix

stdenv.mkDerivation rec {
name = "gnome-shell-wsmatrix-${version}";
version = "9543a73df7bac9476f8adeba9d7a14fdacb57b7d";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you specify a release tag from https://github.com/mzur/gnome-shell-wsmatrix/releases as the version?

pkgs/desktops/gnome-3/extensions/wsmatrix.nix
{ stdenv, fetchFromGitHub, glib }:

stdenv.mkDerivation rec {
name = "gnome-shell-wsmatrix-${version}";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the gnome shell extensions use the convention gnome-shell-extension-... instead of gnome-shell-.... I don't have an opinion here other than "consistency is good", so unless others object, please add -extension here.

pkgs/top-level/all-packages.nix
@@ -22650,6 +22650,7 @@ in
timepp = callPackage ../desktops/gnome-3/extensions/timepp { };
topicons-plus = callPackage ../desktops/gnome-3/extensions/topicons-plus { };
window-corner-preview = callPackage ../desktops/gnome-3/extensions/window-corner-preview { };
wsmatrix = callPackage ../desktops/gnome-3/extensions/wsmatrix.nix { };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move wsmatrix.nix to wsmatrix/default.nix to match the convention of the other extensions?

@jonafato
Copy link
Contributor

jonafato commented Sep 4, 2019

I think we might also deprecate workspace-grid, since it's:

  1. not even available (its nix definition isn't imported)
  2. unmaintained, with wsmatrix taking it over.

Reference for the unmaintained statement: zakkak/workspace-grid#120. I can't speak to the maintained status of it, though there's some discussion on that thread. I'd typically be against removing it without a definite unmaintained status, but given your reasoning plus the fact that it doesn't work in 3.32 (the only gnome version currently supported in nixpkgs), there doesn't seem to be much harm. That said, I'll defer to @aneeshusa on removing it since they're listed as the maintainer.

@chkno
Copy link
Member

chkno commented Dec 7, 2019

Oops: I didn't see this open PR and submitted a ~duplicate one: #75123 . That one addresses the above review comments, if it's easier to continue over there.

@chkno chkno mentioned this pull request Dec 7, 2019
Merged
8 tasks
@jonafato
Copy link
Contributor

jonafato commented Apr 8, 2020

Looks like this was added in #75123, so this PR should be closed.

@ryantm ryantm added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 3, 2020
@stale
Copy link

stale bot commented Jun 5, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 5, 2021
@piegamesde piegamesde closed this Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonafato jonafato jonafato requested changes

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@deepfire @jonafato @chkno @ryantm @piegamesde