Skip to content

Commit

Permalink
refactor: use method reference without cast
Browse files Browse the repository at this point in the history
  • Loading branch information
akutschera committed Sep 15, 2024
1 parent b11da4d commit 47f3045
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public static <T> BuilderInstantiator<T> create(Method builderMethodCandidate, S

private Map<BiFunction, Object> presetValues = new HashMap<>();

public BuilderInstantiator<T> with(BiFunction setter, Object value) {
public <U,V> BuilderInstantiator<T> with(BiFunction<U,V,U> setter, V value) {
presetValues.put(setter, value);
return this;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@
import com.github.nylle.javafixture.testobjects.ClassWithBuilder;
import org.junit.jupiter.api.Test;

import java.util.function.BiFunction;

import static org.assertj.core.api.Assertions.assertThat;

class BuilderInstantiatorTest {
Expand All @@ -33,11 +31,9 @@ void builderCanBeCnfigured() throws NoSuchMethodException {
var sut = BuilderInstantiator.create(ClassWithBuilder.class.getMethod("builder"), SpecimenType.fromClass(ClassWithBuilder.class));

// we seem to need to explicitly cast it like this.
BiFunction<ClassWithBuilder.Builder, Integer, ClassWithBuilder.Builder> setter = ClassWithBuilder.Builder::number;
BiFunction<ClassWithBuilder.Builder, String, ClassWithBuilder.Builder> without = ClassWithBuilder.Builder::string;
var result = sut
.with(setter, 2)
.with(without, null) // we have lambdas, i.e. no method names, so no without
.with(ClassWithBuilder.Builder::number, 2)
.with(ClassWithBuilder.Builder::string, null) // we have lambdas, i.e. no method names, so no without
.invoke(new SpecimenFactory(new Context(new Configuration())), CustomizationContext.noContext());

assertThat(result).isInstanceOf(ClassWithBuilder.class);
Expand Down

0 comments on commit 47f3045

Please sign in to comment.