Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding gitpod configuration #52

Closed
wants to merge 8 commits into from

Conversation

GitMensch
Copy link
Collaborator

this file alone only "prepares" for use of GitPod, but I consider this useful, too

I suggest to additional do the following, after #51:

but as noted, that's "optional"; some benefits of GitPod: nice performance, running without costs, full coding and building possible in the browser from anywhere, when pre-builds are active the development can start nearly in an instant, in theory also easy for people to start coding on the project

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2022

Codecov Report

Merging #52 (743a84f) into gcos4gnucobol-3.x (3d48698) will decrease coverage by 0.12%.
The diff coverage is 65.37%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@                  Coverage Diff                  @@
##           gcos4gnucobol-3.x      #52      +/-   ##
=====================================================
- Coverage              65.29%   65.17%   -0.12%     
=====================================================
  Files                     31       31              
  Lines                  56789    58384    +1595     
  Branches               14851    15380     +529     
=====================================================
+ Hits                   37078    38051     +973     
- Misses                 13885    14402     +517     
- Partials                5826     5931     +105     
Impacted Files Coverage Δ
libcob/coblocal.h 75.00% <ø> (ø)
libcob/mlio.c 52.01% <ø> (+0.18%) ⬆️
libcob/numeric.c 79.75% <ø> (+3.17%) ⬆️
libcob/reportio.c 73.18% <ø> (-0.07%) ⬇️
libcob/screenio.c 9.19% <ø> (-3.73%) ⬇️
libcob/strings.c 81.91% <ø> (ø)
libcob/termio.c 69.87% <ø> (+0.66%) ⬆️
libcob/intrinsic.c 74.16% <40.44%> (+0.02%) ⬆️
cobc/config.c 80.81% <41.66%> (-1.24%) ⬇️
libcob/cconv.c 63.63% <43.07%> (-11.37%) ⬇️
... and 17 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@GitMensch GitMensch force-pushed the patch-2 branch 2 times, most recently from d2653ed to 180b3d9 Compare December 4, 2022 23:10
@GitMensch
Copy link
Collaborator Author

@lefessan @nberth What do you think of this?

A testing should be possible from this URL: https://gitpod.io/#https://github.com/GitMensch/gnucobol-1

(hm, and authorize gitpod, I see that this can be an issue, but maybe you still try that)

@GitMensch
Copy link
Collaborator Author

rebased and rechecked, seems fine to me (one could use the vnc base workspace definition to allow running the manual screen tests; but that can be done, later, too

@GitMensch GitMensch marked this pull request as draft July 4, 2023 20:38
@GitMensch GitMensch marked this pull request as ready for review June 3, 2024 17:17
@GitMensch
Copy link
Collaborator Author

GitMensch commented Jun 3, 2024

Juist found out that I've set that to draft months ago... @ddeclerck do you have suggestions compared to the common CI?Would it be reasonable to use the docker you seem to build on/for gitlab? Does it have all the tools installed and is public accessible?

@GitMensch GitMensch assigned GitMensch and unassigned GitMensch Jun 3, 2024
@GitMensch GitMensch requested a review from ddeclerck June 3, 2024 17:18
@ddeclerck
Copy link
Contributor

Juist found out that I've set that to draft months ago... @ddeclerck do you have suggestions compared to the common CI?

I'm clueless about GitPod...
The proposed configuration seems to "do the job".
Don't know if GitPod allows to upload artifacts (eg. testsuite log) ?

Would it be reasonable to use the docker you seem to build on/for gitlab? Does it have all the tools installed and is public accessible?

Which docker image are you referring to ?

@GitMensch
Copy link
Collaborator Author

GitMensch commented Jun 4, 2024

I'm clueless about GitPod...
The proposed configuration seems to "do the job".

With gitpod you don't have any artifact as it opens an online vscode instance connected to a running docker - you have all the files ready at hand with the current revision used.

Still - if you have any suggestions then feel free to drop them :-)

Which docker image are you referring to ?

I've stumbled yesterday over

image: registry.ocamlpro.com/ocamlpro/ocaml-docker-images:4.12

Maybe that's something reasonable to use in general, and comes with all the dependencies included?

... self answer when checking further down: the dependencies are installed as pre-script, so reworded question: "Shouldn't those be part of a new image that possibly is based on the other one and includes all dependencies - along with those in the gitpod file here and the ones used in the github ci?"

@ddeclerck
Copy link
Contributor

I'm clueless about GitPod...
The proposed configuration seems to "do the job".

With gitpod you don't have any artifact as it opens an online vscode instance connected to a running docker - you have all the files ready at hand with the current revision used.

Still - if you have any suggestions then feel free to drop them :-)

Looks interesting ; I shall give it a try if I find a moment.

Which docker image are you referring to ?

I've stumbled yesterday over

image: registry.ocamlpro.com/ocamlpro/ocaml-docker-images:4.12

Maybe that's something reasonable to use in general, and comes with all the dependencies included?

... self answer when checking further down: the dependencies are installed as pre-script, so reworded question: "Shouldn't those be part of a new image that possibly is based on the other one and includes all dependencies - along with those in the gitpod file here and the ones used in the github ci?"

I wasn't even aware of that GitLab CI 😅. Apparently that was added during early experiments on our internal GitLab instance, before we created the GitHub mirror. The docker image you mention has been made by another team at OCamlPro (I believe it is automatically generated and refreshed from time to time) and is intended for OCaml development. I'd have to check with that team if we can come up with something to use for GnuCOBOL on GitPod.

@GitMensch
Copy link
Collaborator Author

I'd have to check with that team if we can come up with something to use for GnuCOBOL on GitPod.

If I'm not wrong then we could also use this in the github CI (with the goal of decreasing CI minutes, which is also beneficial to the environment).

@GitMensch
Copy link
Collaborator Author

@ddeclerck @lefessan This PR should work as-is already and improve the use of the repo on GitPod. Can you please pull that into the gcos3 and gcos4 branches?

We can come back to adjust this later to care for a possible new base image.
I'll check for the gcos4 one later on as both the CI and the GitPod defintiion should be extended to cater for the multi-io feature.

@ddeclerck
Copy link
Contributor

Hi @GitMensch ,
I manually added the configration file to the gcos4gnucobol-3.x and gc4 branches.

@GitMensch GitMensch closed this Jun 20, 2024
@GitMensch GitMensch deleted the patch-2 branch June 20, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants