Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node 20, add blocking parameter, add tests #341

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Conversation

Germandrummer92
Copy link
Member

Use node 20, add blocking pipeline parameter, add tests.

See https://dev.azure.com/octomind-dev/test-pipeline-task/_build/results?buildId=134&view=logs&j=3ea133f3-ab59-5874-203e-922e94eb6822 for a successful run WITH blocking.

Code is now also much more similar to https://github.com/OctoMind-dev/automagically-action-execute

Copy link
Member

@fabianhinz fabianhinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, some minor comments

automagicallyexecute/src/fetchJson.ts Show resolved Hide resolved
automagicallyexecute/task.json Show resolved Hide resolved
automagicallyexecute/task.json Show resolved Hide resolved
automagicallyexecute/task.json Show resolved Hide resolved
@Germandrummer92 Germandrummer92 enabled auto-merge (squash) October 18, 2024 21:00
@Germandrummer92 Germandrummer92 merged commit bed3203 into main Oct 18, 2024
3 checks passed
@Germandrummer92 Germandrummer92 deleted the blocking-pipeline branch October 18, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants