Fix external links to open in new tab #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Respected projects maintainers I've updated the external links on the bottom of the page to open in a new tab, as discussed. The changes include adding target="_blank" to the relevant links to ensure users are not navigated away from the application. Could someone please review the changes and provide feedback? Your input would be greatly appreciated. Thank you! |
aaronbrethorst
requested changes
Aug 6, 2024
|
Hi @aaronbrethorst, As requested, I have reverted the unrelated changes. The pull request now focuses solely on the issue of external links opening in a new tab. Thank you! |
aaronbrethorst
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved issue #139
Description:
This pull request updates the external links on the bottom of the page to open in a new tab. The change involves adding the target="_blank" attribute to anchor tags linking to GitHub, the App Store, the Play Store, and the Open Transit Software Foundation. This enhancement ensures that when users click on these external links, they are directed to the respective sites in a new browser tab, preserving their current session on the application.
Changes Made:
Added target="_blank" to the GitHub link.
Added target="_blank" to the App Store link.
Added target="_blank" to the Play Store link.
Added target="_blank" to the Open Transit Software Foundation link.
Motivation:
Opening external links in a new tab prevents users from leaving the current application session, providing a better user experience by maintaining the context of the original page.
Testing:
The changes were manually tested to verify that all external links now open in a new tab. No other parts of the application were affected by these changes.
Checklist:
Added target="_blank" to external links
Manually tested the changes
Verified that the change does not impact other parts of the application
Screencast.from.06-08-24.09.37.47.PM.IST.webm