Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improved footer icon and text contrast ratio for better readability in dark mode #61

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

Devmoni
Copy link
Contributor

@Devmoni Devmoni commented Mar 11, 2024

Description:

Fixed #59

Issue fixed:

The issue regarding dim footer icons in dark mode has been successfully resolved.

Changes done:

  • Task 1

Screenshots/Videos

Before :
Screenshot from 2024-03-11 21-15-40

After:
Screenshot from 2024-03-11 23-12-46

✅️ By submitting this PR, I have verified the following

  • Checked to see if a similar PR has already been opened 🤔️
  • Reviewed the contributing guidelines 🔍️
  • Tried squashing the commits into one

…lity in dark mode

Signed-off-by: Devmoni <devmoni97@gmail.com>
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks @Devmoni

@aaronbrethorst aaronbrethorst merged commit 2370700 into OneBusAway:main Mar 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 Bug : Improper contrast of icons in the footer section in dark mode
2 participants