Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): inner well geometry unit tests (#17082) #17311

Merged
merged 1 commit into from
Jan 27, 2025
Merged

feat(api): inner well geometry unit tests (#17082) #17311

merged 1 commit into from
Jan 27, 2025

Conversation

ryanthecoder
Copy link
Contributor

Overview

This just copies the updated well geometry definitions from edge over to chore_release.

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

@ryanthecoder ryanthecoder requested review from a team as code owners January 21, 2025 19:57
sfoster1
sfoster1 approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it copies over some functional changes too. Please make sure that's in the pr title and in the description and eventual commit message.

Assuming we actually want those changes, anyway. Do we?

caila-marashaj
caila-marashaj approved these changes Jan 21, 2025 •
edited
Loading
View reviewed changes
@ryanthecoder ryanthecoder merged commit a2b35d5 into chore_release-8.3.0 Jan 27, 2025
80 of 84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caila-marashaj caila-marashaj caila-marashaj approved these changes

@sfoster1 sfoster1 sfoster1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanthecoder @sfoster1 @caila-marashaj