feat(protocol-designer): update UI for liquids toolbox #17342
Conversation
Modify logic for saving add liquids form, displaying errors, and behavior on confirmation button of toolbox if a form is unsaved. Closes AUTH-1368
|
need to resolve cypress test with @alexjoel42 |
|
Probably failing because the below is covered by my imprecise well-selection cursor.
|
| `, | ||
| } | ||
|
|
||
| export const TertiaryButton = styled(Btn)<{ |
There was a problem hiding this comment.
why can't this be in components already?
There was a problem hiding this comment.
Should i move it there? there is currently a tertiary button in app but not components @jerader
There was a problem hiding this comment.
if this component is the same as tertiary button in app, moving it to component is the best way.
There was a problem hiding this comment.
Unfortunately it required some changes from the app directory. My suggestion is that we address this component and unify in components library after this release, when we have a bit more time to discuss with design the definitive styles (the app tertiary button is used all over the place, and I'm hesitant to make a big change to it at this point). Let me know what you guys think.
There was a problem hiding this comment.
i sort of think we should move this into components now and then unify components and app later.
There was a problem hiding this comment.
Oh I see. That works for me
There was a problem hiding this comment.
i agree with Nick. tertiary button is used a lot in app and seems that the other team is busy for 830.
the change may have a big impact on 830 release.
| @@ -370,7 +370,7 @@ const executeAction = (action: Actions | UniversalActions): void => { | |||
| cy.contains('My liquid!').click() // Action for clicking 'My liquid!' | |||
| break | |||
| case Actions.SetVolumeAndSaveforWells: | |||
| cy.get('input[name="volume"]').type(`150`) // Set volume | |||
| cy.get('input[name="volume"]').type('150', { force: true }) // Set volume | |||
There was a problem hiding this comment.
why did we need to add this?
There was a problem hiding this comment.
I will let @alexjoel42 chime in here. there was an issue with cypress thinking the input element was blocked
Overview
Modify logic for saving add liquids form, displaying errors, and behavior on confirmation button of toolbox if a form is unsaved.
Closes AUTH-1368
Test Plan and Hands on Testing
Changelog
TertiaryButtonto PD atoms (should probably move this to components eventually)Review requests
see test plan
Risk assessment
low