Rqa 3878 tempdeck pd cypress and refactoring of helper functions #17345
+574
−310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nds in PD Edits createNew.ts and ProtocolDesignerModulesTest.cy.ts to make sure that when we have consistent testing for temperature modules RQA 3878
Keeps things up to date
y3rsh
approved these changes
Jan 24, 2025
I am getting this up to date with edge
…for wells, and pass lint checks. Will investigate js checks next
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a refactoring where we are going to execute protocol run steps through StepExecution (oh and btw it also adds a new module testing e2e test!)
Each distinct test component (modules, transfer, mix, etc.) will have its own helper function in support like support/SetupSteps, support/SupportModules
Test Plan and Hands on Testing
These are Cypress tests but we might need to collaborate with dev to handle tests failing because of copy changes .
Changelog
Review requests
Risk assessment
Low.