refactor(protocol-designer, step-generation): remove redundant offset…

[jerader]

… parameters for mix

closes AUTH-1367

Overview

This PR cleans up the redundant offset parameters for mixFormToArgs

MixArgs currently has fields like:

aspirateOffsetFromBottomMm: number
dispenseOffsetFromBottomMm: number
aspirateXOffset: number
dispenseXOffset: number
aspirateYOffset: number
dispenseYOffset: number

This is way more than what a user can actually select in the UI, which is:

Mix tip position:

X position
Y position
Z position

Additionally, there was a bug with the mix advanced setting for a transfer step where the x,y,z offset behavior wasn't consistent. See slack for more details.

Test Plan and Hands on Testing

Review code. Then, test out that the mix x,y,z offsets work correctly for a transfer advanced setting. Add a mix to both the aspirate and dispense and see that the offsets are consistent for aspirate and dispense within a mix. (see slack thread for more details on what to expect) I smoke tested this already and it works as expected now!

Changelog

• remove redundant mix offset parameters: aspirate & dispense x, y, z offsets are now narrowed down to 1 for both aspirate and dispense
• clean up constants so now there is just 1 for the default mm from bottom offset
• fix bug with moveLiquid advanced settings mix for aspirate and dispense

Risk assessment

low-ish

[ddcc4]

Additionally, there was a bug with the mix advanced setting for a transfer step where the x,y,z offset behavior wasn't consistent. See slack for more details.

Yeah, confirm with @sanni-t that the new behavior matches the behavior of the mix inside transfer_liquid(). (I think it does.)