Labware creator adapter fix attempt #17347
Open
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acking offset with module We had a bug in #17238 BREAKING CHANGE: This will change how the stacking offset is calculated so any quirky customer workarounds might stop working. Also if the changes needed to be bigger that will also be tricky GitHub ticket 17238
jerader
reviewed
Jan 24, 2025
| @@ -121,11 +121,15 @@ export function fieldsToLabware( | |||
| }) | |||
| const stackingOffsetWithModule: Record<string, LabwareOffset> = {} | |||
| Object.entries(compatibleModules).forEach(([moduleModel, z]) => { | |||
| const moduleDefinition = getModuleDef2(moduleModel as ModuleModel) | |||
There was a problem hiding this comment.
looks like you need to import ModuleModel! import type { ModuleModel } from '@opentrons/shared-data'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Addressing a customer reported bug where labware's stacked offsets while loaded onto just a module don't account for the module's height.
Test Plan and Hands on Testing
Make custom labware using the module's hights and then check the offsets
Changelog
One line change
Review requests
I want to verify that this doesn't have any wider scope code risk. I don't understand Labware-Creator very well as an ecosystem yet.
Risk assessment
Medium