The Chinese translation is complete. Request a review. #307
Conversation
Because nothing is more important than an introduction to help the reader dive into something as hard as Vulkan
) * Prefer use of dynamic state for viewport and scissor * Slight rewording, working in-page anchor * Updated command buffers chapter and code to use dynamic viewport and scissor state * Updated swap chain recreation chapter No more need to recreate the graphics pipeline as viewport and scissor state are now dynamic * Updated command buffer chapter code to use dynamic viewport and scissor * Removed render pass destruction/creation for swap chain recreation This is not needed anymore * Use dynamic state for viewport and scissor for samples after the fixed function chapter * Use dynamic state for viewport and scissor for samples after the swap chain recreation chapter Removed render pass destruction/creation for swap chain recreation, no longer necessary * Removed duplicate code * Wording change * Changed wording on chapter intro, moved dynamic state paragraph to the top * Fixed wording * Fixed wording * C++ style cast * Wording * Wording * Wording * Added note on renderpass recreation * Apply suggestions from code review Incorporate suggestions Co-authored-by: Alexander Overvoorde <overv161@gmail.com> * Added dynamic state to conclusion chapter * Remove unnecessary link * Remove code referencing command buffers too early Co-authored-by: Alexander Overvoorde <overv161@gmail.com>
append new section showing how to fix `VK_ERROR_INCOMPATIBLE_DRIVER` with latest MoltenVK sdk
Fix the recreateSwapChain() function to match the code, which may cause the "Validation Error" if you resize and close window.
On Fedora, the packages should be libXi-devel and libXxf86vm-devel, instead of libXi and libXxf86vm. Otherwise, by following the tutorial, we might get errors such as: /usr/bin/ld: cannot find -lXxf86vm collect2: error: ld returned 1 exit status make: *** [Makefile:5: VulkanTest] Error 1
|
Any native speakers who can pitch in to review this? @chirsz-ever @fangcun010 |
|
翻译应该放在 |
|
如果是在 Windows 上进行开发可以将 git 配置为提交时使用 LF，checkout 到文件系统中时使用 CRLF1： git config --global core.autocrlf true配置后建议使用 Footnotes |
|
中文路径问题将在 Overv/daux.io#2 被合入后解决。 |
|
发现的一些问题：
排版相关可以参考 中文排版指北。 图形学术语可以参考《游戏引擎架构》中英词汇索引表。 参考 这里 的建议，某些术语可以保留英文原文，如使用“uniform buffer”或“uniform 缓冲”而非“统一缓冲区”，“统一的缓冲区”。 |
Overv
force-pushed
the
main
branch
2 times, most recently
from
f2764d9 to
ddd8649
Compare
|
When will the translation be deployed? @Overv |
|
@orbitgw Would you be willing to go through the chapters and review them? If a native speaker can confirm that it looks good then this can be deployed. |
|
@Overv |
|
@orbitgw That is fine. Perhaps someone else has a chance to look at it earlier. |
|
This PR is a mess with unrelatied modifications and wrong format. The author did not take action or reply to comments for half a year. I think I could start a new translation PR in some days. @Overv How do you think about Overv/daux.io#2? If you think it change too much, It's OK to just add Overv/daux.io@b3ab5c3 to remove hard-coded "Introduction" path, and I will use English file names in the Chinese translation. |
我赞同你的想法，用中文做路径太奇怪了，而且不好访问 |
|
@Overv |
|
@chirsz-ever 我想咱们可以合作一下 |
|
我同意，用英文保留文件名会更方便，这样它们就更容易与其他版本匹配了 翻译准备好发布时，我会修复介绍路径 |
The Chinese translation is complete. Request a review.