Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(indexer): indexing uses SymbolIndexer instead of visitor.rs #1245

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

riederm
Copy link
Collaborator

@riederm riederm commented Jun 13, 2024

The indexer utilizes the visitor-trait to visit nodes that contain symbols. It delegates the concrete work to smaller, specialized indexer-implementations in src/index/indexer

The indexer utilizes the visitor-trait to visit nodes that contain
symbols. It delegates the concrete work to smaller, specialized
indexer-implementations in src/index/indexer
Copy link
Member

@mhasel mhasel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo/commented-out code.
Again a very clean refactor! 🔥

src/index/indexer/implementation_indexer.rs Outdated Show resolved Hide resolved
src/index/indexer/user_type_indexer.rs Outdated Show resolved Hide resolved
src/tests/adr/vla_adr.rs Show resolved Hide resolved
src/tests/adr/vla_adr.rs Show resolved Hide resolved
src/index/indexer.rs Outdated Show resolved Hide resolved
@mhasel mhasel requested review from ghaith and volsa November 27, 2024 15:04
@mhasel mhasel self-requested a review December 4, 2024 10:35
@mhasel mhasel merged commit 416f68a into master Dec 4, 2024
19 checks passed
@mhasel mhasel deleted the mari/indexer_refactoring branch December 4, 2024 10:35
@riederm
Copy link
Collaborator Author

riederm commented Dec 4, 2024

thx guys for finisshing the PR!
❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants