Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial values on methods are passed correctly #1390

Merged
merged 78 commits into from
Jan 27, 2025
Merged

Initial values on methods are passed correctly #1390

merged 78 commits into from
Jan 27, 2025

Conversation

ghaith
Copy link
Collaborator

@ghaith ghaith commented Jan 17, 2025

Methods now behave like functions, the parameters are all passed in the call and not as a struct.
The initial values are set correctly before the call.

Blocked by #1379

ghaith and others added 30 commits November 21, 2024 11:37
Co-authored-by: Michael <mhasel@users.noreply.github.com>
Use one context per module

Co-authored-by: Michael <mhasel@users.noreply.github.com>
@mhasel mhasel requested a review from volsa January 27, 2025 13:53
Copy link
Member

@volsa volsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

src/validation/tests/pou_validation_tests.rs Show resolved Hide resolved
src/index.rs Show resolved Hide resolved
END_PROGRAM
",
);
insta::assert_snapshot!(prg);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a reviewer: No inline snapshots :(

src/codegen/tests/code_gen_tests.rs Show resolved Hide resolved
src/codegen/tests/code_gen_tests.rs Show resolved Hide resolved
src/index.rs Show resolved Hide resolved
@mhasel mhasel merged commit e731987 into master Jan 27, 2025
21 checks passed
@mhasel mhasel deleted the initial_values branch January 27, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants