-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move functions from mixins into KData #559
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📚 Documentation |
Draft
Draft
Draft
Closed
Draft
The protocol stuff also created issues in the documentation of KData. I moved the functions all back into KData, before replacing them. |
fzimmermann89
changed the title
Move KData to data
Move functions from mixing into KData
Jan 6, 2025
fzimmermann89
changed the title
Move functions from mixing into KData
Move functions from mixins into KData
Jan 6, 2025
schuenke
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only one minor comment/question... see below
ckolbPTB
approved these changes
Jan 7, 2025
Merged
fzimmermann89
added a commit
that referenced
this pull request
Jan 8, 2025
also fixes the issue with the KData.__init__ documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the mixins will deprecate or be replaced, moving Kdata back into data makes more sense.
This also fixes the issue with the
KData.__init__
documentationIn one of the later PRs I will remove some of the functions or replace them by the new rearrange.
Stack