-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed FTB because it is no longer in Prism Launcher #323
base: main
Are you sure you want to change the base?
Conversation
PrismLauncher/PrismLauncher#1040 < PR that removed this feature Signed-off-by: Onako2 <79749977+Onako2@users.noreply.github.com>
✅ Deploy Preview for prismlauncher ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I recognise you, I don't know where from lol. There's also |
Ok, I'll add it.. |
Only the sceenshot is wrong. FTB Legacy still exists |
can I count on you when the PrismLauncher/PrismLauncher#235 is done? |
Do you mean to readd? Yes |
Okay, that's fair enough |
Signed-off-by: Onako2 <79749977+Onako2@users.noreply.github.com>
Removed reference of FTB on the About page Signed-off-by: Onako2 <79749977+Onako2@users.noreply.github.com>
uf. I accidentaly selected the wrong branch. How do I change the branch? |
For the PR? You can't. I don't think it's a big deal here though! |
The problem is, that other references aren't in this PR. I could create another PR that contains all other changes |
Huh? Just push those changes to patch-1 |
removed mentions of FTB and updatted screenshot
Isn't it ready to be merged now? What's blocking it? |
I put it on the wrong branch, thanks for reminding me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these screenshots were used on this help page: https://prismlauncher.org/wiki/help-pages/ftb-platform/
make sure to just remove these with the help page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
What do we want to do with this now 8.0 has ftb app import? |
PrismLauncher/PrismLauncher#1040 < PR that removed this feature