Python 3.13 support #2306
Python 3.13 support #2306
Conversation
|
Since 3.8 is EOL, shouldn't we drop support for that too? |
|
I think that Python 3.8 doesn't conflict with adding Python 3.13 support and dropping it is outside of this PR's scope |
|
Fair point :) |
isort/stdlibs/py312.py
Outdated
| @@ -14,7 +14,9 @@ | |||
| "argparse", | |||
| "array", | |||
| "ast", | |||
| "asynchat", | |||
There was a problem hiding this comment.
Please remove these.
They were all removed in 3.12:
https://docs.python.org/3/whatsnew/3.12.html#asynchat-and-asyncore
There was a problem hiding this comment.
I can remove it, but it was added by the scripts. So it will automatically appear on the next run because it's still present in the corresponding documentation: https://docs.python.org/3.12/library/asynchat.html#module-asynchat
Mb it would be better to use stdlibs package or adopt it's approach to modules generation?
There was a problem hiding this comment.
Aha, the problem was caused by the docs re-adding module pages which had bee removed, but as stubs:
Mb it would be better to use stdlibs package or adopt it's approach to modules generation?
Yeah, sounds like a good idea to use stdlibs 👍
There was a problem hiding this comment.
updated the script to use stdlibs and ran it
isort/stdlibs/py313.py
Outdated
| "argparse", | ||
| "array", | ||
| "ast", | ||
| "asynchat", |
There was a problem hiding this comment.
Similarly, this list contains lots of modules that have been removed in 3.12 or earlier.
Was this list created using the mkstdlibs.py script?
There was a problem hiding this comment.
all changes to stdlibbs/py*.py were generated by mkstdlibs.py scripts
use `stdlibs` for stdlibs packages list
|
Awesome! Could you rebase this so we can get this merged? |
|
I had to drop python3.8 support to make builds pass on python3.13 because some packages required a version, which do not support python3.8 (not sure how it passed before the At the same time, the prod package could have been installed with both 3.8 and 3.13, so I'm open to rolling back this commit if 3.8 support is considered more important than builds with python3.13 in PRs |
|
I think it's fine to drop 3.8, as mentioned before, it's already EOL: We could merge this as-is and do a more thorough 3.8 cleanup in another PR. |
Related issue: 2305