Modernize python support #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert 'tests.py' -> 'tests/test_it.py' to enable PyTest discovery. Add pin to Pyramid to defer 2.0 changes.
Drop support for Python 2.7, 3.5, 3.6, 3.7. Drop using 'nosetests' in favor of 'pytest'.
|
Lol you're nuts. I'll try to go over it over the weekend or possibly next week, because the last time I tried it with e.g. youshouldsing under Pyramid 2.X, it was very unhappy. |
|
@mcdonc Thanks. Note that this PR doesn't tackle compatibility with Pyramid 2 (it actually adds a pin against it). The Pyramid-induces changes are purely about deprecations, some of which (laughably) have to be removed / redone for Pyramid 2 support. |
Test failure tracked in #312
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyramid< 2.0dev, until it can be reviewed in depth.pyramid.pkg_resources.cryptacularwith plainbcrypt-- theensconsbuilder thatcryptacularneeds barfs on Python 3.12.