Fix Flaky Client Certificate Authentication Test #1617
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelAHM
requested review from
eshryane,
fmurodov,
isvonja and
maggarwal13
as code owners
eshryane
reviewed
Jan 8, 2025
| assertThat(response, containsString("Found 1 certificate(s).")); | ||
| assertThat(response, containsString("-----BEGIN CERTIFICATE-----")); | ||
| assertThat(response, containsString("-----END CERTIFICATE-----")); | ||
|
|
||
| final ProcessingException processingException = assertThrows(ProcessingException.class, |
There was a problem hiding this comment.
Why are you expecting a ProcessingException ? The test should succeed
There was a problem hiding this comment.
Should the test retry on ProcessingException ? For example
@RetryFor(value = {IOException.class, ProcessingException.class}, attempts = 10, intervalMs = 10000)
There was a problem hiding this comment.
The successful client_certificate test has been replaced and is now an expected failure? And the failure case fail_on_no_client_certificate has been removed? There should be one success and one failure test.
eshryane
reviewed
Jan 8, 2025
| @@ -223,6 +225,8 @@ public void update_person_missing_private_key_unauthorised() throws Exception { | |||
| "mnt-by: OWNER-MNT\n" + | |||
| "source: TEST"); | |||
|
|
|||
| sendUpdateRequest(updatedPerson); | |||
There was a problem hiding this comment.
Why was an extra update added to the test?
eshryane
changed the title
|
Alternative : #1625 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix the flaky (flapping) integration test:
It seems that the retryFor is not enough. Most of the times it works well after performing an OK request.
There are some time that even performing an OK request is not enough, for those situation I think that we should keep the retryFor. Following this, the test are OK
I think that the root issue is with the setup of the IT for Client Certificate. This requires a deeper look at the integration test set up