Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows support #511

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add windows support #511

wants to merge 7 commits into from

Conversation

steven-murray
Copy link
Contributor

@steven-murray steven-murray commented Nov 22, 2024

Description

This adds psutil to the dependencies for the [sim] extra, and moves the import of resource / psutil into the only function that uses it. This means that Windows can now run sims.

Note that some tests still fail on windows (e.g. using miriad files). I haven't dug deep into it, but we could try putting xfails on thins we know will fail and start testing against windows if we want. For now, this update means all matvis tests pass on windows.

Motivation and Context

In testing matvis against pyuvsim, I was trying to use the GPU, and on my laptop that's easier to do on Windows. I found that the pyuvsim comparison tests broke on Windows however, simply because of the import of resource, which is unix-only. This fixes it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Reference simulation update or replacement
  • Documentation change (documentation changes only)
  • Version change
  • Build or continuous integration change

Checklist:

For all pull requests:

Build or continuous integration change checklist:

  • If required or optional dependencies have changed (including version numbers), I have updated the readme to reflect this.
  • If this is a new CI setup, I have added the associated badge to the readme and to references/make_index.py (if appropriate).

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 99.80%. Comparing base (6ea6af1) to head (60703a6).

Files with missing lines Patch % Lines
src/pyuvsim/mpi.py 66.66% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #511      +/-   ##
===========================================
- Coverage   100.00%   99.80%   -0.20%     
===========================================
  Files           10       10              
  Lines         2024     2031       +7     
===========================================
+ Hits          2024     2027       +3     
- Misses           0        4       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bhazelton
Copy link
Member

This is great! The myriad part of pyuvdata doesn't work on Windows, so that's why those break.

@bhazelton
Copy link
Member

Oh, casacore is also not available on Windows, so the measurement set writing should also be skipped on Windows.

@bhazelton
Copy link
Member

I suspect we should update the readme and maybe some other docs to mention windows compatibility.

@bhazelton bhazelton changed the title Allow psutil Add windows support Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants