-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add windows support #511
base: main
Are you sure you want to change the base?
Add windows support #511
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #511 +/- ##
===========================================
- Coverage 100.00% 99.80% -0.20%
===========================================
Files 10 10
Lines 2024 2031 +7
===========================================
+ Hits 2024 2027 +3
- Misses 0 4 +4 ☔ View full report in Codecov by Sentry. |
This is great! The myriad part of pyuvdata doesn't work on Windows, so that's why those break. |
Oh, casacore is also not available on Windows, so the measurement set writing should also be skipped on Windows. |
I suspect we should update the readme and maybe some other docs to mention windows compatibility. |
Description
This adds
psutil
to the dependencies for the[sim]
extra, and moves the import ofresource
/psutil
into the only function that uses it. This means that Windows can now run sims.Note that some tests still fail on windows (e.g. using miriad files). I haven't dug deep into it, but we could try putting xfails on thins we know will fail and start testing against windows if we want. For now, this update means all matvis tests pass on windows.
Motivation and Context
In testing matvis against pyuvsim, I was trying to use the GPU, and on my laptop that's easier to do on Windows. I found that the pyuvsim comparison tests broke on Windows however, simply because of the import of
resource
, which is unix-only. This fixes it.Types of changes
Checklist:
For all pull requests:
Build or continuous integration change checklist: