chore("branding"): add logo #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafaelGSS
reviewed
Jan 20, 2025
| @@ -1,5 +1,9 @@ | |||
| <h1 align="center"> | |||
| 🚀 Bench Node | |||
| <img | |||
| src="https://raw.githubusercontent.com/RafaelGSS/bench-node/refs/heads/main/assets/logo.svg" | |||
There was a problem hiding this comment.
Can you use relative path instead?
There was a problem hiding this comment.
No it's unsure to display it correctly on npm without publishing it (logo)
H4ad
reviewed
Jan 20, 2025
Comment on lines
+1
to
+2
| # We doesn't wan to publish the logo and other | ||
| assets |
There was a problem hiding this comment.
You can add the logos inside the .github to avoid being included in the package.
There was a problem hiding this comment.
Yeah that true. But I chose to create a separate dir to allow user to easily found that.
H4ad
approved these changes
Jan 23, 2025
RafaelGSS
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.npmignoreto not publish assets file