Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Make ACL during archive upload optional #387

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JiriPapousek
Copy link
Collaborator

Description

Our AWS S3 buckets do not allow setting ACLs, so we are making that optional.

Type of change

  • New feature (non-breaking change which adds functionality)

Testing steps

NA

Checklist

  • pre-commit run -a passes
  • updated documentation wherever necessary
  • added or modified tests if necessary
  • updated schemas and validators in insights-data-schemas in case of input/output change

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.76%. Comparing base (0ec2eb7) to head (443b341).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
ccx_messaging/engines/s3_upload_engine.py 75.00% 1 Missing ⚠️
ccx_messaging/utils/s3_uploader.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #387      +/-   ##
==========================================
- Coverage   85.86%   85.76%   -0.11%     
==========================================
  Files          28       28              
  Lines        1196     1201       +5     
==========================================
+ Hits         1027     1030       +3     
- Misses        169      171       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matysek
Copy link
Member

matysek commented Jan 28, 2025

/ok-to-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants