Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): sort from config is ignored #32

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

JeromeSiau
Copy link
Contributor

Hi!

There is a small typo in the getNavigationSort function.
It uses set instead of get, so even if we set a sort in the config file, it is currently ignored

Copy link

what-the-diff bot commented Dec 29, 2023

🎉 PR Summary 🎉

  • Configuration Adjustment in EmailResource.php
    We made a switcheroo in how we interact with our config settings. Now, instead of setting a value with Config::set(...), we're now grabbing it using Config::get(...). It's like asking the system politely for a piece of information instead of telling it what to store. 😄

Remember, these kinds of changes help us retrieve the correct configuration values more efficiently and reduce potential bugs down the road. 🐛➡️🚫

@JeromeSiau JeromeSiau changed the title fix sort from config is ignored fix(): sort from config is ignored Dec 31, 2023
@RickDBCN RickDBCN self-assigned this Jan 2, 2024
@RickDBCN RickDBCN added the bug Something isn't working label Jan 2, 2024
@RickDBCN
Copy link
Owner

RickDBCN commented Jan 2, 2024

Good catch! Many thanks!

@RickDBCN RickDBCN merged commit aefdabf into RickDBCN:main Jan 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants